Skip to content

Conversation

@prakashsvmx
Copy link
Member

Fixes #2929

this happens only when selecting and deleting an object.

fix delete option permission check in sidebar

Test Policy

image

{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "s3:GetBucketLocation",
                "s3:ListBucket"
            ],
            "Resource": [
                "arn:aws:s3:::my-bucket"
            ]
        },
        {
            "Effect": "Allow",
            "Action": [
                "s3:DeleteObject",
                "s3:GetObject",
                "s3:PutObject"
            ],
            "Resource": [
                "arn:aws:s3:::my-bucket/some_path/*"
            ]
        },
        {
            "Effect": "Deny",
            "Action": [
                "s3:DeleteObject"
            ],
            "Resource": [
                "arn:aws:s3:::my-bucket/some_path/*"
            ]
        }
    ]
}

@prakashsvmx prakashsvmx self-assigned this Jul 11, 2023
@prakashsvmx prakashsvmx changed the title fix delete option permission check in sidebar WIP - fix delete option permission check in sidebar Jul 11, 2023
@prakashsvmx prakashsvmx marked this pull request as draft July 11, 2023 15:48
@prakashsvmx prakashsvmx force-pushed the fix-del-permission-check branch 2 times, most recently from 8d4cc59 to e0af33a Compare July 12, 2023 04:28
@prakashsvmx prakashsvmx force-pushed the fix-del-permission-check branch from e0af33a to 5d3004c Compare July 12, 2023 04:40
@prakashsvmx prakashsvmx changed the title WIP - fix delete option permission check in sidebar fix delete share download options permission check in sidebar Jul 12, 2023
@prakashsvmx prakashsvmx marked this pull request as ready for review July 12, 2023 04:42
Copy link
Contributor

@kaankabalak kaankabalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can see the download and delete options with the following policy:

{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Action": [
        "s3:ListBucket",
        "s3:GetBucketLocation"
      ],
      "Resource": [
        "arn:aws:s3:::my-bucket"
      ]
    },
    {
      "Effect": "Allow",
      "Action": [
        "s3:PutObject",
        "s3:DeleteObject",
        "s3:GetObject"
      ],
      "Resource": [
        "arn:aws:s3:::my-bucket/some_path/*"
      ]
    }
  ]
}

@bexsoft bexsoft merged commit 02ed6a6 into minio:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minio console does not correctly apply IAM policies with "*" in resource

5 participants