Integrate mkube storageclass api with UI #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested changes
Jun 3, 2020
restapi/mkube.go
Outdated
| // serverMkube handles calls for mkube | ||
| func serverMkube(client *http.Client, w http.ResponseWriter, req *http.Request) { | ||
| // destination of the request, the mkube server | ||
| req.URL.Path = fmt.Sprintf("/api/v1/%s", strings.TrimPrefix(req.URL.Path, "/api/v1/mkube")) |
There was a problem hiding this comment.
perhaps, you only need to remove the /mkube/ with / that way you don't have the /v1/ in multiple places
There was a problem hiding this comment.
yes but they can potentially be different one is hitting mkube apis and the other one is mcs api.
dvaldivia
previously approved these changes
Jun 3, 2020
dvaldivia
previously approved these changes
Jun 4, 2020
Alevsk
previously approved these changes
Jun 4, 2020
Alevsk
approved these changes
Jun 4, 2020
dvaldivia
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open mcs with flag
MCS_OPERATOR_ONLY=onthen when adding a new Tenant, the storage classes listed should be the same as if you were doingkubectl get storageclasses.storage.k8s.io