Skip to content

Connect List, Add Tenants #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

Connect List, Add Tenants #148

merged 1 commit into from
Jun 2, 2020

Conversation

@dvaldivia
Copy link
Collaborator

Screen Shot 2020-05-27 at 3 50 13 PM

@dvaldivia dvaldivia requested review from Alevsk, bexsoft and cesnietor May 27, 2020 22:51
@dvaldivia dvaldivia self-assigned this May 27, 2020
bexsoft
bexsoft previously approved these changes May 28, 2020
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Alevsk
Alevsk previously approved these changes May 28, 2020
View reviewed changes
cesnietor
cesnietor requested changes May 28, 2020
View reviewed changes
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working

@cesnietor
Copy link
Collaborator

using the request payload:

{"name":"test","service_name":"test","enable_ssl":false,"enable_mcs":false,"access_key":"","secret_key":"","volumes_per_server":0,"volume_configuration":{"size":""},"zones":[{"name":"zone1","servers":4}]}

is giving an "EOF" error on mcs server and the following error on m3:

│ 2020-05-28T21:18:35.2244785Z 2020/05/28 21:18:35 http: panic serving 127.0.0.1:47246: cannot parse '': quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'                              │
│ 2020-05-28T21:18:35.2245699Z goroutine 84 [running]:                                                                                                                                                                            │
│ 2020-05-28T21:18:35.2246526Z net/http.(*conn).serve.func1(0xc00069c000)                                                                                                                                                         │
│ 2020-05-28T21:18:35.2247157Z     /usr/local/go/src/net/http/server.go:1772 +0x139                                                                                                                                               │
│ 2020-05-28T21:18:35.2247514Z panic(0x1552640, 0xc0007d60b0)                                                                                                                                                                     │
│ 2020-05-28T21:18:35.2247829Z     /usr/local/go/src/runtime/panic.go:973 +0x396                                                                                                                                                  │
│ 2020-05-28T21:18:35.2248085Z k8s.io/apimachinery/pkg/api/resource.MustParse(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)                                                                                                        │
│ 2020-05-28T21:18:35.2248567Z     /go/pkg/mod/k8s.io/apimachinery@v0.18.0/pkg/api/resource/quantity.go:127 +0x1c8                                                                                                                │
│ 2020-05-28T21:18:35.2248797Z github.com/minio/m3/restapi.getClusterCreatedResponse(0xc000910200, 0xc0001682d0, 0x7f4cf73f32f0, 0x0)                                                                                             │
│ 2020-05-28T21:18:35.2250252Z     /go/src/github.com/minio/m3/restapi/clusters.go:221 +0x559                                                                                                                                     │
│ 2020-05-28T21:18:35.2250767Z github.com/minio/m3/restapi.registerClusterHandlers.func1(0xc000910200, 0xc0001682d0, 0xc0007de301, 0xc0007740d0)                                                                                  │
│ 2020-05-28T21:18:35.2251091Z     /go/src/github.com/minio/m3/restapi/clusters.go:42 +0x39                                                                                                                                       │
│ 2020-05-28T21:18:35.2251342Z github.com/minio/m3/restapi/operations/admin_api.CreateClusterHandlerFunc.Handle(0x1809590, 0xc000910200, 0xc0001682d0, 0x19a4560, 0xc0007740d0)                                                   │
│ 2020-05-28T21:18:35.2251588Z     /go/src/github.com/minio/m3/restapi/operations/admin_api/create_cluster.go:36 +0x3a                                                                                                            │
│ 2020-05-28T21:18:35.2251855Z github.com/minio/m3/restapi/operations/admin_api.(*CreateCluster).ServeHTTP(0xc0004ffa60, 0x19de1c0, 0xc0000940e0, 0xc000910200)                                                                   │
│ 2020-05-28T21:18:35.2252136Z     /go/src/github.com/minio/m3/restapi/operations/admin_api/create_cluster.go:71 +0x16d                                                                                                           │
│ 2020-05-28T21:18:35.2252364Z github.com/go-openapi/runtime/middleware.NewOperationExecutor.func1(0x19de1c0, 0xc0000940e0, 0xc000910200)                                                                                         │
│ 2020-05-28T21:18:35.2252619Z     /go/pkg/mod/github.com/go-openapi/runtime@v0.19.4/middleware/operation.go:28 +0x75                                                                                                             │
│ 2020-05-28T21:18:35.2252821Z net/http.HandlerFunc.ServeHTTP(0xc000799cc0, 0x19de1c0, 0xc0000940e0, 0xc000910200)                                                                                                                │
│ 2020-05-28T21:18:35.2253109Z     /usr/local/go/src/net/http/server.go:2012 +0x44                                                                                                                                                │
│ 2020-05-28T21:18:35.2253334Z github.com/go-openapi/runtime/middleware.NewRouter.func1(0x19de1c0, 0xc0000940e0, 0xc000910000)                                                                                                    │
│ 2020-05-28T21:18:35.2253557Z     /go/pkg/mod/github.com/go-openapi/runtime@v0.19.4/middleware/router.go:76 +0x356                                                                                                               │
│ 2020-05-28T21:18:35.2253837Z net/http.HandlerFunc.ServeHTTP(0xc0004b99e0, 0x19de1c0, 0xc0000940e0, 0xc000910000)                                                                                                                │
│ 2020-05-28T21:18:35.2254268Z     /usr/local/go/src/net/http/server.go:2012 +0x44                                                                                                                                                │
│ 2020-05-28T21:18:35.225451Z github.com/go-openapi/runtime/middleware.Redoc.func1(0x19de1c0, 0xc0000940e0, 0xc000910000)                                                                                                         │
│ 2020-05-28T21:18:35.2254708Z     /go/pkg/mod/github.com/go-openapi/runtime@v0.19.4/middleware/redoc.go:72 +0x286                                                                                                                │
│ 2020-05-28T21:18:35.2255543Z net/http.HandlerFunc.ServeHTTP(0xc000299840, 0x19de1c0, 0xc0000940e0, 0xc000910000)                                                                                                                │
│ 2020-05-28T21:18:35.2256208Z     /usr/local/go/src/net/http/server.go:2012 +0x44                                                                                                                                                │
│ 2020-05-28T21:18:35.2256641Z github.com/go-openapi/runtime/middleware.Spec.func1(0x19de1c0, 0xc0000940e0, 0xc000910000)                                                                                                         │
│ 2020-05-28T21:18:35.2256873Z     /go/pkg/mod/github.com/go-openapi/runtime@v0.19.4/middleware/spec.go:46 +0x188                                                                                                                 │
│ 2020-05-28T21:18:35.2257132Z net/http.HandlerFunc.ServeHTTP(0xc000299880, 0x19de1c0, 0xc0000940e0, 0xc000910000)                                                                                                                │
│ 2020-05-28T21:18:35.2257388Z     /usr/local/go/src/net/http/server.go:2012 +0x44                                                                                                                                                │
│ 2020-05-28T21:18:35.2257638Z net/http.serverHandler.ServeHTTP(0xc000094000, 0x19de1c0, 0xc0000940e0, 0xc000910000)                                                                                                              │
│ 2020-05-28T21:18:35.2258055Z     /usr/local/go/src/net/http/server.go:2807 +0xa3                                                                                                                                                │
│ 2020-05-28T21:18:35.2258286Z net/http.(*conn).serve(0xc00069c000, 0x19e1600, 0xc00008c000)                                                                                                                                      │
│ 2020-05-28T21:18:35.2258524Z     /usr/local/go/src/net/http/server.go:1895 +0x86c                                                                                                                                               │
│ 2020-05-28T21:18:35.2258666Z created by net/http.(*Server).Serve                                                                                                                                                                │
│ 2020-05-28T21:18:35.2258873Z     /usr/local/go/src/net/http/server.go:2933 +0x35c

@dvaldivia dvaldivia dismissed stale reviews from Alevsk and bexsoft via 7e2981f May 28, 2020 22:03
@dvaldivia dvaldivia force-pushed the list-clusters-add-clusters branch 4 times, most recently from 6281e45 to 85c9519 Compare June 1, 2020 19:07
@dvaldivia dvaldivia changed the title Connect List,Add Clusters Connect List, Add Tenants Jun 1, 2020
@dvaldivia dvaldivia force-pushed the list-clusters-add-clusters branch from 85c9519 to 203a1bd Compare June 1, 2020 22:04
bexsoft
bexsoft approved these changes Jun 2, 2020
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit 8af3665 into minio:master Jun 2, 2020
@dvaldivia dvaldivia deleted the list-clusters-add-clusters branch June 2, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cesnietor cesnietor cesnietor approved these changes

@bexsoft bexsoft bexsoft approved these changes

+1 more reviewer

@Alevsk Alevsk Alevsk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dvaldivia dvaldivia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dvaldivia @cesnietor @Alevsk @bexsoft