Skip to content

Conversation

@bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented May 19, 2020

fixes #53

What does this do?

Added service accounts page to settings module

How to test

  • Create an account with permissions to see service accounts or add this fragment of code into line 350 of Console.tsx:
<Route
                    exact
                    path="/service_accounts"
                    component={ServiceAccounts}
                  />
  • Go into Configurations Lists > service_accounts > Edit Icon
  • Click on create service account & write a valid policy
  • Click on create button, the policy should appear in the list
  • Click on the delete button of the recently created policy, the policy should be deleted

Screen Shot 2020-05-18 at 11 37 52 PM
Screen Shot 2020-05-18 at 11 37 34 PM
Screen Shot 2020-05-18 at 11 37 28 PM
Screen Shot 2020-05-18 at 11 37 15 PM

@bexsoft bexsoft added the WIP This PR is WIP and cannot be merged yet label May 19, 2020
@bexsoft bexsoft requested review from Alevsk, cesnietor and dvaldivia May 19, 2020 05:42
@bexsoft bexsoft self-assigned this May 19, 2020
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should put the Service Accounts in the menu as a main feature, probably below Buckets. Since Service Accounts is going to be probably the most used feature after buckets.

@cesnietor
Copy link
Collaborator

I'm also trying to test it, there is no permission needed to See service Accounts, but I can't see the page load. And even having admin:* is not showing also.

@bexsoft
Copy link
Collaborator Author

bexsoft commented May 19, 2020

I'm also trying to test it, there is no permission needed to See service Accounts, but I can't see the page load. And even having admin:* is not showing also.

Just fixed this issue, page is now fully working

cesnietor
cesnietor previously approved these changes May 19, 2020
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft removed the WIP This PR is WIP and cannot be merged yet label May 19, 2020
@cesnietor cesnietor self-requested a review May 19, 2020 20:39
@dvaldivia dvaldivia merged commit 989e6f3 into minio:master May 19, 2020
@bexsoft bexsoft deleted the clean-service-accounts-ui branch May 19, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service Accounts

3 participants