Skip to content

Conversation

@dvaldivia
Copy link
Collaborator

Detects https and sets the Websocket protocol to wss
on asset not found we return index.html so the react application can handle 404

@dvaldivia dvaldivia requested review from Alevsk, bexsoft and cesnietor May 8, 2020 22:56
@dvaldivia dvaldivia self-assigned this May 8, 2020
Alevsk
Alevsk previously approved these changes May 8, 2020
Alevsk
Alevsk previously approved these changes May 8, 2020
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit cf8472b into minio:master May 8, 2020
@dvaldivia dvaldivia deleted the wss-spa branch May 8, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants