This repository was archived by the owner on Feb 13, 2026. It is now read-only.
fix(api): Don't send multiple responses for one request#21651
Merged
harshavardhana merged 1 commit intominio:masterfrom Oct 24, 2025
Merged
fix(api): Don't send multiple responses for one request#21651harshavardhana merged 1 commit intominio:masterfrom
harshavardhana merged 1 commit intominio:masterfrom
Conversation
In some cases multiple responses are being sent for one request, causing the API server to incorrectly drop connections. This change introduces a ResponseWriter which tracks whether a response has already been sent. This is used to prevent a response being sent if something already has (e.g. by a preconditions check function). Fixes minio#21633.
mjs
changed the title
mjs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
This change introduces a ResponseWriter which tracks whether a response has already been sent. This is used to prevent a response being sent if something already has (e.g. by a preconditions check function).
Motivation and Context
In some cases multiple responses are being sent for one request, causing the API server to incorrectly drop connections.
Fixes #21633.
How to test this PR?
See the reproduction steps in #21633. This issue no longer reproducible with this change in place.
Types of changes
Checklist:
commit-idorPR #here)