Fix broken tests with ENABLE_HTTPS=0 #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
requested review from
poornas and
vadmeste
and removed request for
poornas
harshavardhana
commented
Sep 4, 2018
| @@ -1672,7 +1674,7 @@ def main(): | |||
| try: | |||
| access_key = os.getenv('ACCESS_KEY', 'Q3AM3UQ867SPQQA43P2F') | |||
| secret_key = os.getenv('SECRET_KEY', | |||
There was a problem hiding this comment.
BTW all the indentation changes I had to do since my emacs complained a lot, there are a lot of formatting errors in this file which I avoided but - these changes were automatically done by my editor.
poornas
previously requested changes
Sep 4, 2018
harshavardhana
force-pushed
the
fix-tests
branch
from
e97c9d8 to
f4ce39c
Compare
poornas
approved these changes
Sep 4, 2018
|
Adding regression label since this was supposed to be fixed in the last release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c798b8c broke our functional
tests for non TLS server setups. This PR fixes this by
skipping encryption tests on non-TLS servers.
Fixes #691