-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove ObjectUplaoder
and turn stream uploading
#1227
Conversation
ObjectUplaoder
and turn stream uploading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, but here are some nitpicks.
getContentLength function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Changes look good to me. 👍
ref #1045
previously, if user want to upload a stream, for example:
s3.putObject('...', '...', fs.createReadStream('...'))
, minio-js will usemaxObjectSize
as object size and 500 mb as chunk size.after this patch, when
putObject
is used with a stream created byfs.createReadStream
, minio-js will try to read file size as object size, and use proper chunk size.