Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: bucketExists #1223

Merged
merged 18 commits into from
Nov 30, 2023
Merged

refactor: bucketExists #1223

merged 18 commits into from
Nov 30, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Oct 31, 2023

No description provided.

@trim21 trim21 marked this pull request as ready for review October 31, 2023 11:25
@trim21 trim21 closed this Nov 5, 2023
@trim21 trim21 deleted the bucketExists branch November 14, 2023 07:54
@trim21 trim21 restored the bucketExists branch November 14, 2023 07:54
@trim21 trim21 reopened this Nov 14, 2023
@trim21 trim21 marked this pull request as draft November 14, 2023 08:31
@trim21 trim21 marked this pull request as ready for review November 22, 2023 11:12
aldy505
aldy505 reviewed Nov 25, 2023
View reviewed changes
Copy link
Contributor

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldy505
Copy link
Contributor

aldy505 commented Nov 27, 2023

Oh anyway, quick question. Why didn't this PR update the minio.d.ts file like other PR did? The bucketExists signature should be deleted, right?

@trim21
Copy link
Contributor Author

trim21 commented Nov 27, 2023

Oh anyway, quick question. Why didn't this PR update the minio.d.ts file like other PR did? The bucketExists signature should be deleted, right?

I forget this

@trim21 trim21 marked this pull request as draft November 27, 2023 04:24
@trim21 trim21 marked this pull request as ready for review November 27, 2023 04:31
prakashsvmx
prakashsvmx previously approved these changes Nov 27, 2023
View reviewed changes
aldy505
aldy505 reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prakashsvmx
prakashsvmx previously approved these changes Nov 27, 2023
View reviewed changes
prakashsvmx
prakashsvmx previously approved these changes Nov 28, 2023
View reviewed changes
kaankabalak
kaankabalak reviewed Nov 28, 2023
View reviewed changes
src/minio.js Outdated Show resolved Hide resolved
trim21
trim21 commented Nov 29, 2023
View reviewed changes
src/minio.js Outdated Show resolved Hide resolved
@trim21
Copy link
Contributor Author

trim21 commented Nov 29, 2023

@kaankabalak

kaankabalak
kaankabalak approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@kaankabalak kaankabalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx prakashsvmx merged commit 5573400 into minio:master Nov 30, 2023
14 checks passed
trim21 added a commit to trim21/minio-js that referenced this pull request Nov 30, 2023
@trim21
refactor: bucketExists (minio#1223)
2b77475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldy505 aldy505 aldy505 left review comments

@kaankabalak kaankabalak kaankabalak approved these changes

@prakashsvmx prakashsvmx prakashsvmx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trim21 @aldy505 @prakashsvmx @kaankabalak