Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor setObjectLegalHold and getObjectLegalHold apis #1198

Merged
merged 7 commits into from
Sep 14, 2023
Merged

refactor setObjectLegalHold and getObjectLegalHold apis #1198

merged 7 commits into from
Sep 14, 2023

Conversation

prakashsvmx
Copy link
Member

refactor setObjectLegalHold and getObjectLegalHold api

@prakashsvmx prakashsvmx self-assigned this Aug 2, 2023
@prakashsvmx prakashsvmx marked this pull request as ready for review August 2, 2023 12:40
kaankabalak
kaankabalak reviewed Aug 4, 2023
View reviewed changes
docs/API.md Outdated Show resolved Hide resolved
kaankabalak
kaankabalak reviewed Aug 4, 2023
View reviewed changes
docs/API.md Outdated Show resolved Hide resolved
trim21
trim21 reviewed Aug 10, 2023
View reviewed changes
src/internal/client.ts Outdated Show resolved Hide resolved
trim21
trim21 reviewed Aug 10, 2023
View reviewed changes
src/internal/client.ts Outdated Show resolved Hide resolved
trim21
trim21 reviewed Aug 10, 2023
View reviewed changes
src/minio.d.ts Show resolved Hide resolved
@prakashsvmx prakashsvmx force-pushed the ref-get-set-legal-hold branch 2 times, most recently from 85daed0 to e014662 Compare September 5, 2023 06:10
kaankabalak
kaankabalak previously approved these changes Sep 12, 2023
View reviewed changes
trim21
trim21 reviewed Sep 13, 2023
View reviewed changes
src/internal/client.ts Outdated Show resolved Hide resolved
src/internal/type.ts Show resolved Hide resolved
trim21
trim21 reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@trim21 trim21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx prakashsvmx merged commit a3ff47c into minio:master Sep 14, 2023
14 checks passed
@prakashsvmx prakashsvmx deleted the ref-get-set-legal-hold branch September 14, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trim21 trim21 trim21 left review comments

@kaankabalak kaankabalak kaankabalak approved these changes

Assignees

@prakashsvmx prakashsvmx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prakashsvmx @trim21 @kaankabalak