fix use configured region from constructor for makebucket (#1293)

minio · May 13, 2024 · fc976b9 · fc976b9
1 parent fd89297
commit fc976b9
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -193,7 +193,7 @@ The complete API Reference is available here:
 - [list-objects-v2.js](https://github.com/minio/minio-js/blob/master/examples/list-objects-v2.js)
 - [list-objects-v2-with-metadata.js](https://github.com/minio/minio-js/blob/master/examples/list-objects-v2-with-metadata.js) (Extension)
 - [bucket-exists.mjs](https://github.com/minio/minio-js/blob/master/examples/bucket-exists.mjs)
-- [make-bucket.js](https://github.com/minio/minio-js/blob/master/examples/make-bucket.js)
+- [make-bucket.mjs](https://github.com/minio/minio-js/blob/master/examples/make-bucket.js)
 - [remove-bucket.mjs](https://github.com/minio/minio-js/blob/master/examples/remove-bucket.mjs)
 - [list-incomplete-uploads.js](https://github.com/minio/minio-js/blob/master/examples/list-incomplete-uploads.js)
 - [get-bucket-versioning.mjs](https://github.com/minio/minio-js/blob/master/examples/get-bucket-versioning.js)

diff --git a/README_zh_CN.md b/README_zh_CN.md
@@ -155,7 +155,7 @@ mc ls play/europetrip/
 * [list-objects.js](https://github.com/minio/minio-js/blob/master/examples/list-objects.js)
 * [list-objects-v2.js](https://github.com/minio/minio-js/blob/master/examples/list-objects-v2.js)
 * [bucket-exists.mjs](https://github.com/minio/minio-js/blob/master/examples/bucket-exists.mjs)
-* [make-bucket.js](https://github.com/minio/minio-js/blob/master/examples/make-bucket.js)
+* [make-bucket.mjs](https://github.com/minio/minio-js/blob/master/examples/make-bucket.js)
 * [remove-bucket.mjs](https://github.com/minio/minio-js/blob/master/examples/remove-bucket.mjs)
 * [list-incomplete-uploads.js](https://github.com/minio/minio-js/blob/master/examples/list-incomplete-uploads.js)
 

diff --git a/examples/make-bucket.js → examples/make-bucket.mjs b/examples/make-bucket.js → examples/make-bucket.mjs
@@ -24,6 +24,11 @@ const s3Client = new Minio.Client({
   accessKey: 'YOUR-ACCESSKEYID',
   secretKey: 'YOUR-SECRETACCESSKEY',
 })
+
+// Create a bucket name my-bucketname-nr.
+await s3Client.makeBucket('my-bucketname-nr')
+console.log('Success')
+
 // Create a bucket name my-bucketname.
 await s3Client.makeBucket('my-bucketname', 'us-west-1')
 

diff --git a/src/internal/client.ts b/src/internal/client.ts
@@ -892,10 +892,9 @@ export class TypedClient {
       headers['x-amz-bucket-object-lock-enabled'] = true
     }
 
-    if (!region) {
-      region = DEFAULT_REGION
-    }
-    const finalRegion = region // type narrow
+    // For custom region clients  default to custom region specified in client constructor
+    const finalRegion = this.region || region || DEFAULT_REGION
+
     const requestOpt: RequestOption = { method, bucketName, headers }
 
     try {