fix

examples/compose-object-test-example.js

@@ -20,8 +20,8 @@ const os = require('os')
 const splitFile = require('split-file')
 const fs = require('fs')
 
-var Minio = require('../dist/main/minio')
-var Helpers = require('../dist/main/helpers')
+var Minio = require('minio')
+var Helpers = require('minio/dist/main/helpers')
 
 var s3Client = new Minio.Client({
   endPoint: 's3.amazonaws.com',

examples/compose-object.js

@@ -17,8 +17,8 @@
 // Note: YOUR-ACCESSKEYID, YOUR-SECRETACCESSKEY, my-bucketname and my-objectname
 // are dummy values, please replace them with original values.
 
-var Minio = require('../dist/main/minio')
-var Helpers = require('../dist/main/helpers')
+var Minio = require('minio')
+var Helpers = require('minio/dist/main/helpers')
 
 var s3Client = new Minio.Client({
   endPoint: 's3.amazonaws.com',

examples/minio/listen-bucket-notification.js

@@ -17,7 +17,7 @@
 // Note that `listenBucketNotification` is only available for MinIO, and not
 // Amazon.
 
-const Minio = require('../')
+const Minio = require('minio')
 
 var s3Client = new Minio.Client({
   endPoint: '...',

examples/select-object-content.js

@@ -17,7 +17,7 @@
 // Note: YOUR-ACCESSKEYID, YOUR-SECRETACCESSKEY, my-bucketname
 // and my-objectname are dummy values, please replace them with original values.
 
-var Minio = require('../dist/main/minio')
+var Minio = require('minio')
 
 var s3Client = new Minio.Client({
   endPoint: 's3.amazonaws.com',

src/helpers.ts

@@ -174,6 +174,7 @@ export interface ICopyDestinationOptions {
    */
   RetainUntilDate?: string
   Mode?: RETENTION_MODES
+  MetadataDirective?: 'COPY' | 'REPLACE'
 }
 
 export class CopyDestinationOptions {
@@ -185,6 +186,7 @@ export class CopyDestinationOptions {
   private readonly LegalHold?: 'on' | 'off'
   private readonly RetainUntilDate?: string
   private readonly Mode?: RETENTION_MODES
+  private readonly MetadataDirective?: string
 
   constructor({
     Bucket,
@@ -195,6 +197,7 @@ export class CopyDestinationOptions {
     LegalHold,
     RetainUntilDate,
     Mode,
+    MetadataDirective,
   }: ICopyDestinationOptions) {
     this.Bucket = Bucket
     this.Object = Object
@@ -204,6 +207,7 @@ export class CopyDestinationOptions {
     this.LegalHold = LegalHold
     this.Mode = Mode // retention mode
     this.RetainUntilDate = RetainUntilDate
+    this.MetadataDirective = MetadataDirective
   }
 
   getHeaders(): RequestHeaders {
@@ -238,6 +242,10 @@ export class CopyDestinationOptions {
       }
     }
 
+    if (this.MetadataDirective) {
+      headerOptions[`X-Amz-Metadata-Directive`] = this.MetadataDirective
+    }
+
     if (this.Encryption) {
       const encryptionHeaders = getEncryptionHeaders(this.Encryption)
       for (const [key, value] of Object.entries(encryptionHeaders)) {

src/internal/client.ts

@@ -71,7 +71,7 @@ export interface ClientOptions {
   pathStyle?: boolean
   credentialsProvider?: CredentialProvider
   s3AccelerateEndpoint?: string
-  transportAgent?: http.Agent | https.Agent
+  transportAgent?: http.Agent
 }
 
 export type RequestOption = Partial<IRequest> & {
@@ -211,7 +211,6 @@ export class TypedClient {
 
     if (params.credentialsProvider) {
       this.credentialsProvider = params.credentialsProvider
-      void this.checkAndRefreshCreds()
     }
 
     this.regionMap = {}
@@ -256,6 +255,24 @@ export class TypedClient {
     this.reqOptions = _.pick(options, requestOptionProperties)
   }
 
+  /**
+   *  This is s3 Specific and does not hold validity in any other Object storage.
+   */
+  private getAccelerateEndPointIfSet(bucketName?: string, objectName?: string) {
+    if (!isEmpty(this.s3AccelerateEndpoint) && !isEmpty(bucketName) && !isEmpty(objectName)) {
+      // http://docs.aws.amazon.com/AmazonS3/latest/dev/transfer-acceleration.html
+      // Disable transfer acceleration for non-compliant bucket names.
+      if (bucketName.includes('.')) {
+        throw new Error(`Transfer Acceleration is not supported for non compliant bucket:${bucketName}`)
+      }
+      // If transfer acceleration is requested set new host.
+      // For more details about enabling transfer acceleration read here.
+      // http://docs.aws.amazon.com/AmazonS3/latest/dev/transfer-acceleration.html
+      return this.s3AccelerateEndpoint
+    }
+    return false
+  }
+
   /**
    * returns options object that can be used with http.request()
    * Takes care of constructing virtual-host-style or path-style hostname
@@ -296,7 +313,7 @@ export class TypedClient {
 
     // For Amazon S3 endpoint, get endpoint based on region.
     if (isAmazonEndpoint(host)) {
-      const accelerateEndPoint = this.getAccelerateEndPointIfSet(bucketName!, objectName)
+      const accelerateEndPoint = this.getAccelerateEndPointIfSet(bucketName, objectName)
       if (accelerateEndPoint) {
         host = `${accelerateEndPoint}`
       } else {
@@ -355,24 +372,6 @@ export class TypedClient {
     } satisfies https.RequestOptions
   }
 
-  /**
-   *  This is s3 Specific and does not hold validity in any other Object storage.
-   */
-  private getAccelerateEndPointIfSet(bucketName: string, objectName?: string) {
-    if (!isEmpty(this.s3AccelerateEndpoint) && !isEmpty(bucketName) && !isEmpty(objectName)) {
-      // http://docs.aws.amazon.com/AmazonS3/latest/dev/transfer-acceleration.html
-      // Disable transfer acceleration for non-compliant bucket names.
-      if (bucketName.includes('.')) {
-        throw new Error(`Transfer Acceleration is not supported for non compliant bucket:${bucketName}`)
-      }
-      // If transfer acceleration is requested set new host.
-      // For more details about enabling transfer acceleration read here.
-      // http://docs.aws.amazon.com/AmazonS3/latest/dev/transfer-acceleration.html
-      return this.s3AccelerateEndpoint
-    }
-    return false
-  }
-
   public async setCredentialsProvider(credentialsProvider: CredentialProvider) {
     if (!(credentialsProvider instanceof CredentialProvider)) {
       throw new Error('Unable to get credentials. Expected instance of CredentialProvider')

src/internal/type.ts

@@ -1,5 +1,4 @@
 import type * as http from 'node:http'
-import type * as https from 'node:https'
 
 export type Binary = string | Buffer
 
@@ -46,7 +45,7 @@ export enum LEGAL_HOLD_STATUS {
   DISABLED = 'OFF',
 }
 
-export type Transport = typeof http | typeof https
+export type Transport = Pick<typeof http, 'request'>
 
 export interface IRequest {
   protocol: string

src/minio.d.ts

@@ -1,7 +1,7 @@
 // imported from https://github.com/DefinitelyTyped/DefinitelyTyped/blob/93cfb0ec069731dcdfc31464788613f7cddb8192/types/minio/index.d.ts
+/* eslint-disable @typescript-eslint/no-explicit-any */
 
 import { EventEmitter } from 'node:events'
-import type { RequestOptions } from 'node:https'
 import type { Readable as ReadableStream } from 'node:stream'
 
 import type {
@@ -637,8 +637,6 @@ export class Client extends TypedClient {
   // Other
   newPostPolicy(): PostPolicy
 
-  setRequestOptions(options: RequestOptions): void
-
   // Minio extensions that aren't necessary present for Amazon S3 compatible storage servers
   extensions: {
     listObjectsV2WithMetadata(

src/minio.js

@@ -443,9 +443,7 @@ export class Client extends TypedClient {
         (result, cb) => {
           objStat = result
           // Create any missing top level directories.
-          fs.mkdir(path.dirname(filePath), { recursive: true }, (err) => {
-            cb(err)
-          })
+          fs.mkdir(path.dirname(filePath), { recursive: true }, (err) => cb(err))
         },
         (cb) => {
           partFile = `${filePath}.${objStat.etag}.part.minio`

tests/functional/functional-tests.js

@@ -4136,7 +4136,7 @@ describe('functional tests', function () {
 
     step('Clean up temp directory part files', (done) => {
       if (isSplitSuccess) {
-        fs.rmSync(tmpSubDir, { recursive: true, force: true })
+        fs.rmdirSync(tmpSubDir)
       }
       done()
     })

tsconfig.json

@@ -16,5 +16,6 @@
     "sourceMap": true,
     "outDir": "./dist/main/",
     "rootDir": "./src"
-  }
+  },
+  "exclude": ["dist/**/*", "node_modules/**/*"]
 }