-
Notifications
You must be signed in to change notification settings - Fork 509
Add missing fields as per S3 specification #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing fields as per S3 specification #1618
Conversation
0fc2947 to
2dc3195
Compare
0ee6b79 to
cdceb4b
Compare
bd5d6ef to
e58019e
Compare
* listBuckets(ListBucketsArgs) breaks backward compatibility due to unlimited bucket listing Signed-off-by: Bala.FA <bala@minio.io>
e58019e to
1005fa8
Compare
shtripat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| } | ||
|
|
||
| @Root(name = "EventBridgeConfiguration") | ||
| public static class EventBridgeConfiguration {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we plan to implement this in future with details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see any fields in S3 specification. It is empty ATM
|
Hi @balamurugana , apologies if this is the wrong avenue for such a question; I didn't find contact instructions in the project readme. I'm wondering, do you know when the changes from this PR will make it to the next release? I'm currently using the latest release (8.5.17), where CompleteMultipartUploadOutput is still missing the "ChecksumCRC64NVME" field and (if I'm reading correctly) needs to be renamed to CompleteMultipartUploadResult. I believe this is resulting in the warning below in our logs every time there's an upload to S3. I think this is not really causing problems, because I can see from the Minio client code that the warning is logged despite successful upload, but I'd like to keep track of when we can upgrade and stop seeing this in our logs. Thanks for your time! |
unlimited bucket listing