Skip to content

Conversation

@balamurugana
Copy link
Member

@balamurugana balamurugana commented Jan 23, 2025

  • listBuckets(ListBucketsArgs) breaks backward compatibility due to
    unlimited bucket listing

harshavardhana
harshavardhana previously approved these changes Jan 23, 2025
@balamurugana balamurugana force-pushed the Add-missing-fields-as-per-S3-specification branch from 0fc2947 to 2dc3195 Compare January 23, 2025 08:28
@balamurugana balamurugana marked this pull request as draft January 23, 2025 08:29
@balamurugana balamurugana force-pushed the Add-missing-fields-as-per-S3-specification branch 2 times, most recently from 0ee6b79 to cdceb4b Compare January 23, 2025 12:27
@balamurugana balamurugana marked this pull request as ready for review January 23, 2025 12:28
@balamurugana balamurugana force-pushed the Add-missing-fields-as-per-S3-specification branch 3 times, most recently from bd5d6ef to e58019e Compare January 24, 2025 03:31
* listBuckets(ListBucketsArgs) breaks backward compatibility due to
  unlimited bucket listing

Signed-off-by: Bala.FA <bala@minio.io>
@balamurugana balamurugana force-pushed the Add-missing-fields-as-per-S3-specification branch from e58019e to 1005fa8 Compare January 24, 2025 07:27
Copy link

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

}

@Root(name = "EventBridgeConfiguration")
public static class EventBridgeConfiguration {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we plan to implement this in future with details?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see any fields in S3 specification. It is empty ATM

@balamurugana balamurugana merged commit 0f533e8 into minio:master Jan 25, 2025
8 checks passed
@balamurugana balamurugana deleted the Add-missing-fields-as-per-S3-specification branch January 25, 2025 02:05
@tabiStein
Copy link

Hi @balamurugana , apologies if this is the wrong avenue for such a question; I didn't find contact instructions in the project readme.

I'm wondering, do you know when the changes from this PR will make it to the next release? I'm currently using the latest release (8.5.17), where CompleteMultipartUploadOutput is still missing the "ChecksumCRC64NVME" field and (if I'm reading correctly) needs to be renamed to CompleteMultipartUploadResult. I believe this is resulting in the warning below in our logs every time there's an upload to S3.

I think this is not really causing problems, because I can see from the Minio client code that the warning is logged despite successful upload, but I'd like to keep track of when we can upgrade and stop seeing this in our logs.

"message": "S3 service returned unknown XML for CompleteMultipartUpload REST API. <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n\n<CompleteMultipartUploadResult xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\"><Location>REDACTED</Location><Bucket>REDACTED</Bucket><Key>REDACTED</Key><ETag>REDACTED</ETag><ChecksumCRC64NVME>REDACTED</ChecksumCRC64NVME><ChecksumType>FULL_OBJECT</ChecksumType></CompleteMultipartUploadResult>",
"logger_name": "io.minio.S3Base"

Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants