Infer XML namespace using connectHost #96
Conversation
src/Network/Minio/Data.hs
Outdated
| , connectAccessKey = "" | ||
| , connectSecretKey = "" | ||
| , connectIsSecure = True | ||
| , connectSvcNamespace = "http://doc.s3.amazonaws.com/2006-03-01" |
There was a problem hiding this comment.
This looks like a bug in GCS, why do you need to enforce namespace? @krisis can we not unmarshal/marshal without it?
There was a problem hiding this comment.
Even if we have no way to avoid it, I would prefer to avoid providing this as part of connectInfo since this is clearly a bug in GCS and they should fix it. So for such a reason we could simply handle this internally based on the connectHost variable pointing to GCS.
There was a problem hiding this comment.
@donatello @harshavardhana so, should I check if `connectHost == "storage.googleapis.com" and use a different xml namespace?
There was a problem hiding this comment.
Yes, this seems to be a good way.
src/Network/Minio/Data.hs
Outdated
| , connectAccessKey = "" | ||
| , connectSecretKey = "" | ||
| , connectIsSecure = True | ||
| , connectSvcNamespace = "http://doc.s3.amazonaws.com/2006-03-01" |
There was a problem hiding this comment.
Yes, this seems to be a good way.
While GCS is S3 v4 compatible, it uses a different xml namespace url than AWS (and Minio).
krisis
changed the title
|
There are some buidl warnings: |
That would be my mistake data AdminErrJSON = AdminErrJSON { aeCode :: Text
, aeMessage :: Text
} deriving (Eq, Show)
instance FromJSON AdminErrJSON where
parseJSON = withObject "AdminErrJSON" $ \v -> AdminErrJSON
<$> v .: "Code"
<*> v .: "Message"
parseErrResponseJSON :: (MonadIO m) => LByteString -> m ServiceErr
parseErrResponseJSON jsondata =
case eitherDecode jsondata of
Right (AdminErrJSON code message) -> return $ toServiceErr code message
Left err -> throwIO $ MErrVJsonParse $ T.pack errSince we didn't use the aeCode it complains, is there a way to turn this off? |
While GCS is S3 v4 compatible, it uses a different xml namespace url
than AWS (and Minio).