Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AssumeRole STS API #188

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

donatello
Copy link
Member

This change adds support for requesting temporary object storage credentials using the STS API. Some breaking changes are introduced to enable this support:

  • Credentials type has been removed. Use the CredentialValue type instead. Corresponding to this the type signature for setCreds has changed, though the functionality is the same.
  • The type alias Provider has been renamed to CredentialLoader to avoid naming confusion.

@donatello donatello requested a review from krisis May 3, 2023 19:00
@donatello donatello force-pushed the sts branch 6 times, most recently from 1843ea6 to 5cb7945 Compare May 3, 2023 20:41
This change adds support for requesting temporary object storage
credentials using the STS API. Some breaking changes are introduced to
enable this support:

- `Credentials` type has been removed. Use the `CredentialValue` type
instead. Corresponding to this the type signature for `setCreds` has
changed, though the functionality is the same.
- The type alias `Provider` has been renamed to `CredentialLoader` to
avoid naming confusion.
Copy link
Member

@krisis krisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donatello donatello merged commit fa62ed5 into minio:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants