CI: Add support for GHC 8.10, stack and live-server testing #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
previously requested changes
Jun 15, 2020
donatello
force-pushed
the
ci
branch
6 times, most recently
from
695e339 to
d720f9b
Compare
donatello
force-pushed
the
ci
branch
4 times, most recently
from
c7bdfe3 to
f346c34
Compare
donatello
commented
Jun 23, 2020
.github/workflows/haskell-cabal.yml
Outdated
Comment on lines
26
to
31
| - ghc: 8.6 | ||
| os: windows-latest | ||
| experimental: false | ||
| - ghc: 8.10 | ||
| os: windows-latest | ||
| experimental: false |
There was a problem hiding this comment.
These are the same by default right? Don;t think we need these.
.github/workflows/haskell-stack.yml
Outdated
Comment on lines
25
to
35
| - ghc: 8.6 | ||
| os: windows-latest | ||
| experimental: false | ||
| - ghc: 8.10 | ||
| os: windows-latest | ||
| experimental: false | ||
|
|
||
| # Appears to be buggy to build in windows with ghc 8.4 and 8.8 | ||
| - ghc: 8.4 | ||
| os: windows-latest | ||
| experimental: true |
There was a problem hiding this comment.
In stack we are only building with 8.8, so we dont need these as well.
krisis
force-pushed
the
ci
branch
3 times, most recently
from
78a500c to
5b9ebeb
Compare
donatello
dismissed
harshavardhana’s stale review
Minio is running with 4 disks now.
|
Windows builds that fail due to an unrelated error have been marked experimental, so CI can enforce that other build configurations must succeed. We will be merging this now, and making a release subsequently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.