Skip to content

test: add mint test case for metadata with non-us-ascll #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented May 29, 2025

test: add mint test case for metadata with non-us-ascll
depend on this pr #2106

test: add mint test case for metadata with non-us-ascll
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Should be trivial to expand with a few more cases.

@harshavardhana
Copy link
Member

can you look at the failed test?

01T00:00:00Z","ReplicationRequest":false,"RetentionTimestamp":"0001-01-01T00:00:00Z","TaggingTimestamp":"0001-01-01T00:00:00Z","LegalholdTimestamp":"0001-01-01T00:00:00Z","ReplicationValidityCheck":false}},"size":0},"status":"FAIL","message":"Expected upload object metadata test: öha, das sollte but got =?UTF-8?b?w7ZoYSwgZGFzIHNvbGx0ZQ==?="}
panic: Test failed with message: Expected upload object metadata test: öha, das sollte but got =?UTF-8?b?w7ZoYSwgZGFzIHNvbGx0ZQ==?=, err: <nil>

goroutine 1 [running]:
main.logError({0xe3a02b, 0x21}, {0xc6a92f, 0x35}, 0xc0001f6690, {0xc0002c8721?, 0x20?, 0x1104860?}, {0x0, 0x0}, ...)
	/home/runner/work/minio-go/minio-go/functional_tests.go:163 +0x3d4
main.testPutObjectMetadataNonUSASCIIV2()
	/home/runner/work/minio-go/minio-go/functional_tests.go:11475 +0xa4f
main.main()
	/home/runner/work/minio-go/minio-go/functional_tests.go:13876 +0x42f
make: *** [Makefile:33: functional-test] Error 2
Error: Process completed with exit code 2.

Remember this may only work with AiStor MinIO so we need to have tests to skip with open source MinIO. You can peek into the Server http header btw for this.

@jiuker
Copy link
Contributor Author

jiuker commented Jun 4, 2025

can you look at the failed test?

01T00:00:00Z","ReplicationRequest":false,"RetentionTimestamp":"0001-01-01T00:00:00Z","TaggingTimestamp":"0001-01-01T00:00:00Z","LegalholdTimestamp":"0001-01-01T00:00:00Z","ReplicationValidityCheck":false}},"size":0},"status":"FAIL","message":"Expected upload object metadata test: öha, das sollte but got =?UTF-8?b?w7ZoYSwgZGFzIHNvbGx0ZQ==?="}
panic: Test failed with message: Expected upload object metadata test: öha, das sollte but got =?UTF-8?b?w7ZoYSwgZGFzIHNvbGx0ZQ==?=, err: <nil>

goroutine 1 [running]:
main.logError({0xe3a02b, 0x21}, {0xc6a92f, 0x35}, 0xc0001f6690, {0xc0002c8721?, 0x20?, 0x1104860?}, {0x0, 0x0}, ...)
	/home/runner/work/minio-go/minio-go/functional_tests.go:163 +0x3d4
main.testPutObjectMetadataNonUSASCIIV2()
	/home/runner/work/minio-go/minio-go/functional_tests.go:11475 +0xa4f
main.main()
	/home/runner/work/minio-go/minio-go/functional_tests.go:13876 +0x42f
make: *** [Makefile:33: functional-test] Error 2
Error: Process completed with exit code 2.

Remember this may only work with AiStor MinIO so we need to have tests to skip with open source MinIO. You can peek into the Server http header btw for this.

When the #2106 get merged, restart the test will fix this.

add more language
@harshavardhana harshavardhana merged commit 496595d into minio:master Jun 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants