Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes .net4.6~.net4.71 framework support issue for ssl protocol setting #799

Closed

Conversation

ebozduman
Copy link
Collaborator

Subnet cusomer hit the error Operation not supported in this platform while creating a certificate identity provider in net462.

That is because System.Net.Http.HttpClientHandler did not support SslProtocols property to set the protocol type for frameworks before net472 release.

So the protocol type is needed to be set using System.Net.ServicePointManager.SecurityProtocol property to support older frameworks like net462.

@ebozduman ebozduman force-pushed the standardChartered-SubnetIssue8212 branch from 9128d35 to 3db8d8b Compare July 2, 2023 11:26
@martijn00
Copy link
Contributor

@ebozduman can you rebase this one?

@martijn00
Copy link
Contributor

@ebozduman it looks like something went wrong? Did you merge instead of force rebase?

@ebozduman ebozduman force-pushed the standardChartered-SubnetIssue8212 branch 2 times, most recently from 0662842 to 6e2b747 Compare July 10, 2023 05:07
@ebozduman
Copy link
Collaborator Author

ebozduman commented Jul 10, 2023

I still see the CRLF issue in my branch and I was trying to fix it.

The problem is dotnet regitlint check hits the CRLF => LF issue and not proceeding further during build test.

I think we need to revert the PR #798 to go back to the old .gitattribute setting.
However, text=auto also does not help, so we need to set text=lf first.

I expect this forced commit will be cleaned up when the CRLF => LF replacement PR #802, I've just created at crlf_cleanup branch is merged into this PR.

@ebozduman ebozduman force-pushed the standardChartered-SubnetIssue8212 branch from 6e2b747 to c08102a Compare July 15, 2023 04:07
@martijn00
Copy link
Contributor

@ebozduman maybe its better to just start a new branch from master and copy over these fixes and make a new PR?

@ebozduman
Copy link
Collaborator Author

@martijn00

I agree. I'll create a new PR and close this one.

@ebozduman
Copy link
Collaborator Author

Created a new PR, #836, which supersedes this one.
So, this one is closed.

@ebozduman ebozduman closed this Aug 11, 2023
@ebozduman ebozduman deleted the standardChartered-SubnetIssue8212 branch August 14, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants