-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes .net4.6~.net4.71 framework support issue for ssl protocol setting #799
Fixes .net4.6~.net4.71 framework support issue for ssl protocol setting #799
Conversation
9128d35
to
3db8d8b
Compare
@ebozduman can you rebase this one? |
@ebozduman it looks like something went wrong? Did you merge instead of force rebase? |
0662842
to
6e2b747
Compare
I still see the CRLF issue in my branch and I was trying to fix it. The problem is I think we need to revert the PR #798 to go back to the old .gitattribute setting. I expect this forced commit will be cleaned up when the CRLF => LF replacement PR #802, I've just created at |
6e2b747
to
c08102a
Compare
@ebozduman maybe its better to just start a new branch from master and copy over these fixes and make a new PR? |
I agree. I'll create a new PR and close this one. |
Created a new PR, #836, which supersedes this one. |
Subnet cusomer hit the error
Operation not supported in this platform
while creating a certificate identity provider innet462
.That is because
System.Net.Http.HttpClientHandler
did not supportSslProtocols
property to set the protocol type for frameworks beforenet472
release.So the protocol type is needed to be set using
System.Net.ServicePointManager.SecurityProtocol
property to support older frameworks likenet462
.