-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder refactoring including WithBucket. #454
Builder refactoring including WithBucket. #454
Conversation
2a23d8c
to
40035b4
Compare
40035b4
to
d74450a
Compare
Minio/DataModel/Args.cs
Outdated
@@ -36,6 +38,7 @@ public static Hashtable CloneHashTable(Hashtable h) | |||
} | |||
public Args() | |||
{ | |||
this.RequestMethod = Method.HEAD; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is not assigned, the request is HEAD.
d74450a
to
977bd43
Compare
977bd43
to
bb5a664
Compare
are you planning to refactor all the bucket operations in this PR? other than that, looks good to me. Using abstract class here is a nice improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.