Builder refactoring including WithBucket. #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigUstad
force-pushed
the
minio-dotnet-builder-refactor-constructor
branch
from
2a23d8c
to
40035b4
Compare
BigUstad
changed the title
BigUstad
force-pushed
the
minio-dotnet-builder-refactor-constructor
branch
from
40035b4
to
d74450a
Compare
kannappanr
reviewed
Sep 8, 2020
Minio/DataModel/Args.cs
Outdated
| @@ -36,6 +38,7 @@ public static Hashtable CloneHashTable(Hashtable h) | |||
| } | |||
| public Args() | |||
| { | |||
| this.RequestMethod = Method.HEAD; | |||
There was a problem hiding this comment.
If it is not assigned, the request is HEAD.
kannappanr
reviewed
Sep 8, 2020
kannappanr
reviewed
Sep 8, 2020
kannappanr
reviewed
Sep 8, 2020
BigUstad
force-pushed
the
minio-dotnet-builder-refactor-constructor
branch
from
d74450a
to
977bd43
Compare
BigUstad
force-pushed
the
minio-dotnet-builder-refactor-constructor
branch
from
977bd43
to
bb5a664
Compare
|
are you planning to refactor all the bucket operations in this PR? other than that, looks good to me. Using abstract class here is a nice improvement. |
poornas
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.