fix: build on linux/mips64 #4899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add cross compilation to CI. This includes all the archs we intend to publish production binaries for. `linux/mips64` was broken previously, and this is fixed by updating github.com/shirou/gopsutil/v3 to the latest version.
|
We can ignore vulncheck fail - fixed in #4898 |
harshavardhana
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also add cross compilation to CI. This includes all the archs we intend
to publish production binaries for.
linux/mips64was broken previously, and this is fixed by updatinggithub.com/shirou/gopsutil/v3 to the latest version.
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)