Add sa command to support service accounts #3105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
force-pushed
the
service-account
branch
from
a8171af to
2cbebd6
Compare
vadmeste
changed the title
7 tasks
vadmeste
force-pushed
the
service-account
branch
2 times, most recently
from
7ef6ed0 to
ace55aa
Compare
vadmeste
changed the title
|
Not WIP anymore |
vadmeste
changed the title
harshavardhana
requested changes
Mar 21, 2020
vadmeste
changed the title
7 tasks
A new command is added to `mc admin user` command called svc and that's to create new services accounts from existing users. It is also possible to show credentials of the existing service accounts. `mc admin user sa generate PARENT-USER [POLICY_FILE]` `mc admin user sa show SERVICE_ACCOUNT_ACCESS_KEY`
vadmeste
force-pushed
the
service-account
branch
from
ace55aa to
e6d9c52
Compare
vadmeste
changed the title
|
Not WIP. SA command supports empty policy now |
harshavardhana
requested changes
Mar 23, 2020
Co-Authored-By: Harshavardhana <harsha@minio.io>
vadmeste
force-pushed
the
service-account
branch
from
5076719 to
a5f3b1d
Compare
There was a problem hiding this comment.
LGTM, lets get this reviewed by @abperiasamy everything else is working fine.
|
@vadmeste can you get this reviewed from @abperiasamy ? |
6 tasks
|
Closing this PR as this is deprecated and not going to be implemented, as this functionality completely moves to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new command is added to
mc admin usercommand called svcand that's to create new services accounts from existing users.
It is also possible to show credentials of the existing service
accounts.
mc admin user svc generateandmc admin user svc show