Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove all unnecessary Dockerfiles from repo #3340

Merged
merged 1 commit into from
May 9, 2024
Merged

remove all unnecessary Dockerfiles from repo #3340

merged 1 commit into from
May 9, 2024

Conversation

harshavardhana
Copy link
Member

No description provided.

@harshavardhana harshavardhana mentioned this pull request May 8, 2024
Closed
@cesnietor
Copy link
Collaborator

We need to remove also:
.dockerignore
Also update https://github.com/minio/console/blob/master/DEVELOPMENT.md since it has some stale docker docs.

@harshavardhana harshavardhana force-pushed the remove-all branch 2 times, most recently from 061f5cd to 5321efe Compare May 8, 2024 16:57
@cesnietor
Copy link
Collaborator

@harshavardhana did you do make assets? there's no need to do that, we do that only during releases.

@harshavardhana
Copy link
Member Author

@harshavardhana did you do make assets? there's no need to do that, we do that only during releases.

was trying to the pdfjs-dist fixed but looks like that's not the right way to do it.

cesnietor
cesnietor reviewed May 8, 2024
View reviewed changes
DEVELOPMENT.md Outdated Show resolved Hide resolved
cesnietor
cesnietor approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bexsoft
bexsoft approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, UI Vulnerability will be handled in a separate PR

@bexsoft bexsoft merged commit 1058efb into minio:master May 9, 2024
31 of 33 checks passed
@harshavardhana harshavardhana deleted the remove-all branch May 9, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bexsoft bexsoft bexsoft approved these changes

@cesnietor cesnietor cesnietor approved these changes

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

Assignees

@harshavardhana harshavardhana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshavardhana @cesnietor @bexsoft