Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade superagent package to fix vulnerability #3314

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

cesnietor
Copy link
Collaborator

fixes:

Run yarn audit --groups dependencies
yarn audit v1.22.22
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ critical      │ Formidable arbitrary file upload                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ formidable                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=3.2.[4](https://github.com/minio/console/actions/runs/8824893639/job/24228205249?pr=3313#step:4:5)                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ superagent                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ superagent > formidable                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://www.npmjs.com/advisories/1097147                     │
└───────────────┴──────────────────────────────────────────────────────────────┘
1 vulnerabilities found - Packages audited: 41[5](https://github.com/minio/console/actions/runs/8824893639/job/24228205249?pr=3313#step:4:6)
Severity: 1 Critical
Done in 1.19s.

now:

yarn audit --groups dependencies
yarn audit v1.22.19
0 vulnerabilities found - Packages audited: 414
✨  Done in 1.11s.

@cesnietor cesnietor self-assigned this Apr 25, 2024
@cesnietor cesnietor marked this pull request as ready for review April 25, 2024 00:15
Copy link
Contributor

@kaankabalak kaankabalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the vulnerability check is passing now. 👍

@cesnietor cesnietor merged commit ee6d1ed into minio:master Apr 25, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants