Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing permissions validation to rewind button #3282

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Apr 4, 2024

What does this do?

Added missing permissions validation to Rewind button

How does it look?

Screenshot 2024-04-03 at 6 26 16 p m

How to test?

Create a user and assign the following policy

{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Deny",
      "Action": ["s3:CreateBucket", "s3:DeleteBucket"],
      "Resource": ["arn:aws:s3:::*"]
    },
    {
      "Effect": "Allow",
      "Action": ["s3:ListBucket"],
      "Resource": ["arn:aws:s3:::bucketname"]
    },
    {
      "Effect": "Allow",
      "Action": ["s3:GetBucketLocation"],
      "Resource": ["arn:aws:s3:::bucketname"]
    },
    {
      "Effect": "Allow",
      "Action": ["s3:GetObject"],
      "Resource": [
        "arn:aws:s3:::bucketname/firstlevel",
        "arn:aws:s3:::bucketname/firstlevel/*"
      ]
    },
    {
      "Effect": "Allow",
      "Action": ["s3:*"],
      "Resource": [
        "arn:aws:s3:::bucketname/firstlevel/secondlevel*",
        "arn:aws:s3:::bucketname/firstlevel/secondlevel/*"
      ]
    }
  ]
}

Rewind button should remain disabled

Add the s3:GetBucketVersioning permission to the bucket next to s3:GetBucketLocation, button should enable and tooltip should change

@kaankabalak
Copy link
Contributor

Seems like the part where we changed the Permission Tests is timing out on CI:

Run npx testcafe "chrome:headless" web-app/tests/permissions-8/ --skip-js-errors
 Running tests in:
 - Chrome 123.0.6312.58 / Ubuntu 22.0[4](https://github.com/minio/console/actions/runs/8548461999/job/23422222912?pr=3282#step:9:5)

 Rewind Testing
 ✓ Rewind works in bucket
Error: The action 'Run TestCafe Tests' has timed out after [5](https://github.com/minio/console/actions/runs/8548461999/job/23422222912?pr=3282#step:9:6) minutes.

@bexsoft bexsoft force-pushed the policy-rewind branch 2 times, most recently from d4c05b5 to 3811c61 Compare April 4, 2024 18:54
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@bexsoft bexsoft merged commit 963c8f1 into minio:master Apr 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants