mui Grid component replacement #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
requested review from
pjuarezd,
cniackz,
reivaj05,
cesnietor,
allanrogerr,
dvaldivia,
prakashsvmx,
kaankabalak,
adriangitvitz,
jinapurapu and
dilverse
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
bexsoft
force-pushed
the
update-file-preview
branch
from
c1feade
to
adf8caf
Compare
prakashsvmx
approved these changes
Oct 11, 2023
|
CSV files are downloading on preview Screen.Recording.2023-10-11.at.12.45.46.PM.mov |
Hi @jinapurapu! This issue should not be related to this change as only styles are affected by this. will review accordingly in another PR |
dvaldivia
approved these changes
Oct 11, 2023
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Replaced Grid component from mui with mds equivalent, also migrated PreviewFileContent component to mds
How does it look?