Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playwright Test #2693

Closed
wants to merge 1 commit into from
Closed

Conversation

cniackz
Copy link
Collaborator

@cniackz cniackz commented Mar 6, 2023

Objective:

Start exploring playwright to complement testcafe and if we like it, migrate to playwright little by little.

How to manually test:

  1. Have console running at port 5005 as we normally test
  2. Under playwright/tests new added folder run:
npx playwright test
  • This will execute verify-title.spec.ts which is a TypeScript test that checks just the title to contain MinIO
  • Expected result is:
$ npx playwright test

Running 1 test using 1 worker

  ✓  1 example.spec.ts:3:5 › has title (624ms)

  1 passed (1.1s)

Dependencies:

Screenshot 2023-03-07 at 9 33 31 AM

@cniackz cniackz added the enhancement New feature or request label Mar 6, 2023
@cniackz cniackz self-assigned this Mar 6, 2023
@cniackz cniackz force-pushed the add-playwright-test-2 branch 6 times, most recently from 300c66f to 18f35f3 Compare March 7, 2023 14:23
@cniackz cniackz changed the title [WIP] - Add playwright Test Add playwright Test Mar 7, 2023
cd $GITHUB_WORKSPACE/playwright
npx playwright test
- uses: actions/upload-artifact@v3
if: always()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to run this step if tests failed?

@@ -0,0 +1,209 @@
name: Workflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed because we can use it to run only playwright in github actions, mainly for testing but can also be removed but manual intervention will be needed to run standalone mode.... Anyway I will soon close this PR because we have a better approach in other PR.

@cniackz
Copy link
Collaborator Author

cniackz commented Mar 12, 2023

Thank you @reivaj05 for the review, but we are having new approach in #2702, please help us review it there.

@cniackz cniackz closed this Mar 12, 2023
@cniackz cniackz deleted the add-playwright-test-2 branch March 12, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants