Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handlers that will communicate with release service #2651

Merged
merged 5 commits into from
Feb 9, 2023
Merged

Add handlers that will communicate with release service #2651

merged 5 commits into from
Feb 9, 2023

Conversation

reivaj05
Copy link
Contributor

@reivaj05 reivaj05 commented Feb 9, 2023

No description provided.

@kaankabalak
Copy link
Contributor

Hi @reivaj05, I don't think this is anything significant, but the lint check seems to be complaining about the following:

Error: restapi/admin_releases.go:60:2: var-naming: var serviceUrl should be serviceURL (revive)
	serviceUrl := getReleaseServiceURL()

@dvaldivia dvaldivia merged commit 6fbb4b5 into minio:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bexsoft bexsoft bexsoft approved these changes

@dvaldivia dvaldivia dvaldivia approved these changes

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

@cniackz cniackz Awaiting requested review from cniackz

@dilverse dilverse Awaiting requested review from dilverse

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

Assignees

@reivaj05 reivaj05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reivaj05 @kaankabalak @dvaldivia @bexsoft