Increase coverage #2551
Merged
Increase coverage #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
pjuarezd,
cniackz,
reivaj05,
allanrogerr,
prakashsvmx,
kaankabalak,
bexsoft,
jinapurapu and
dilverse
|
Hi @dvaldivia, seems like the Lint check is failing, would it be possible for you to take a look at it? Thanks 🙏 |
|
done @kaankabalak |
|
Seems like the coverage limit check is failing now with the following message: |
|
@kaankabalak dang it, was trying to bring it above threshold hahaha will add some more |
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
dvaldivia
force-pushed
the
increase-cov
branch
from
5ec45c4
to
cc42568
Compare
dilverse
approved these changes
Jan 5, 2023
kaankabalak
approved these changes
Jan 5, 2023
allanrogerr
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com