Set and if statements do not seem to be working

[tymerica]

I copied the if statements from the wiki, because my personal if statements didnt work (I was trying to get it to evaluate functions in the if statement to allow for more direct access to game data) but before I could even get to that, i couldn't get basic if statements working.

<<set $gold to 1>> A: Hello player! Do you have enough gold? <<if $gold is 1>> A: Looks like you need more gold! (This will only appear if $gold is equal to 1.) <<elseif $gold > 1>> A: Good work! (This will only appear if $gold is greater than 1.) <<else>> A: Come back when you have some gold! (This will only appear if $gold is less than 1.) <<endif>>

It would not step past the set step, and if i tried to resume the yarntree manually in the set callback i got a stackoverflow, i also tried manually setting it by the operation, and still didn't seem to work.

then i just tried if statements, it would never go to the line under any if statement although i made sure it evaluated by debugging in my ide, it just seemed to stop after it went through the if else if checks

A: Hello player! Do you have enough gold? <<if 5 is 1>> A: Looks like you need more gold! (This will only appear if $gold is equal to 1.) <<elseif 5 > 1>> A: Good work! (This will only appear if $gold is greater than 1.) <<else>> A: Come back when you have some gold! (This will only appear if $gold is less than 1.) <<endif>>
it would never execute the A: Good work!

there may be a step i'm missing, but just dropping either of these into a node would stop the node in it's tracks.

[tymerica]

Also sorry about not squashing my commits, i forgot :---(

[tomcashman]

No problem :) I'll investigate this issue now.

[tomcashman]

I just noticed your example is missing an <<endif>> - not sure if this is the cause of the issue, still investigating but I've been able to reproduce the issue.

I'll make the parser throw an exception when if/elseif statements aren't closed correctly.

[tymerica]

I wanted to mention I also tested it with an <<endif>>!

[tymerica]

I can also give you the code im writing about on making if statements call nodes that have "acceptable ranges" based on the return of a function called through reflection, it will simplify the language a lot! And if not i can keep it my own side project, but if that sounds something you would be interested in let me know! (I'm only asking here because I do not have your contact info, but if youd like to know about it / would want me to give it to you hit me up )

[tomcashman]

Are <> and <>! valid Yarn syntax? I don't remember those in the specification.

[tymerica]

It was a mistake of mine, I didn't put the code around it so it escaped it ://

[tomcashman]

I added a commit to throw the if/endif pairing exception but I can't reproduce this issue. I've added an integration test for it and it passes. Maybe you can test by modifying the test input file with your content to see does the issue occur?

[tymerica]

So, i followed the stacktrace through, and I used the same nodes as the one in the test in my game, and my only actions are
setCurrentNode("Start")
tree.resume(state)
then it successfully hits a line that i send to the player
then i tree.resume(state) again, and it evaluates the boolean correctly, and it calls setOperation to the correct one, and it calls resume, but I never get the onYarnLine method called the second time.
It is weird because I see it calling it, and then it never shows up in the listener

title: Start
tags: yellow green
colorID: 0
position: 444,216
---
A: Hello player! Do you have enough gold? I get this message in my onYarnLine
<<if 1 is 1>> it executes this evaluation correctly and calls set operation and resume
A: Looks like you need more gold! (This will only appear if $gold is equal to 1.) this never shows up in the onYarnLine
<<elseif 1 > 1>>
A: Good work!
<<else>>
A: Come back when you have some gold! (This will only appear if $gold is less than 1.)
<<endif>>
===

and I get to here YarnNode line 32 return ((YarnOperation)this.operations.get(yarnState.getCurrentOperation())).resume(yarnState, listeners); but it seemingly doesnt resume the state or advance to the next operation

and if I dont pass the first one if statement, it never evaluates the second one or ever goes into the else if no matter what i set the variables to. im still investigating