Made some small optimizations to Dictionaries and Enumerables #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

michelebastione merged 5 commits into mini-software:master from michelebastione:master

Feb 12, 2025

Merged

Made some small optimizations to Dictionaries and Enumerables #724

Added safe IDisposable cast to IEnumerator

Annotations

10 warnings

tests/MiniExcelTests/MiniExcelIssueAsyncTests.cs#L359

'MiniExcel.QueryAsDataTableAsync(string, bool, string, ExcelType, string, IConfiguration, CancellationToken)' is obsolete: 'QueryAsDataTable is not recommended, because it'll load all data into memory.'

tests/MiniExcelTests/MiniExcelIssueAsyncTests.cs#L488

'MiniExcel.QueryAsDataTableAsync(string, bool, string, ExcelType, string, IConfiguration, CancellationToken)' is obsolete: 'QueryAsDataTable is not recommended, because it'll load all data into memory.'

tests/MiniExcelTests/MiniExcelIssueTests.cs#L376

'MiniExcel.QueryAsDataTable(string, bool, string, ExcelType, string, IConfiguration)' is obsolete: 'QueryAsDataTable is not recommended, because it'll load all data into memory.'

tests/MiniExcelTests/MiniExcelIssueAsyncTests.cs#L612

'MiniExcel.QueryAsDataTableAsync(string, bool, string, ExcelType, string, IConfiguration, CancellationToken)' is obsolete: 'QueryAsDataTable is not recommended, because it'll load all data into memory.'

tests/MiniExcelTests/MiniExcelIssueAsyncTests.cs#L733

'MiniExcel.QueryAsDataTableAsync(string, bool, string, ExcelType, string, IConfiguration, CancellationToken)' is obsolete: 'QueryAsDataTable is not recommended, because it'll load all data into memory.'

tests/MiniExcelTests/MiniExcelIssueAsyncTests.cs#L744

'MiniExcel.QueryAsDataTableAsync(string, bool, string, ExcelType, string, IConfiguration, CancellationToken)' is obsolete: 'QueryAsDataTable is not recommended, because it'll load all data into memory.'

tests/MiniExcelTests/MiniExcelIssueTests.cs#L1326

'MiniExcel.QueryAsDataTable(string, bool, string, ExcelType, string, IConfiguration)' is obsolete: 'QueryAsDataTable is not recommended, because it'll load all data into memory.'

tests/MiniExcelTests/MiniExcelIssueTests.cs#L1659

'MiniExcel.QueryAsDataTable(string, bool, string, ExcelType, string, IConfiguration)' is obsolete: 'QueryAsDataTable is not recommended, because it'll load all data into memory.'

tests/MiniExcelTests/MiniExcelIssueTests.cs#L2105

'MiniExcel.QueryAsDataTable(string, bool, string, ExcelType, string, IConfiguration)' is obsolete: 'QueryAsDataTable is not recommended, because it'll load all data into memory.'

tests/MiniExcelTests/MiniExcelIssueTests.cs#L2231

'MiniExcel.QueryAsDataTable(string, bool, string, ExcelType, string, IConfiguration)' is obsolete: 'QueryAsDataTable is not recommended, because it'll load all data into memory.'

The logs for this run have expired and are no longer available.