Skip to content

fix(ci): register_submission fails on every fork PR (pull_request_target checkout guard) - #233

Closed
claytonlin1110 wants to merge 1 commit into
mini-router:mainfrom
claytonlin1110:sn74-claytonlin1110-ci-pr-target-fix
Closed

claytonlin1110 wants to merge 1 commit into
mini-router:mainfrom
claytonlin1110:sn74-claytonlin1110-ci-pr-target-fix

Conversation

@claytonlin1110

Copy link
Copy Markdown
Contributor

Summary

  • Every miner fork PR currently fails the register_submission job: actions/checkout refuses to check out fork code under pull_request_target (pwn-request guard). Examples: run #500 and run #501 on PR feat(optim): R8 training baselines (RS / SFT / REINFORCE) (#231) #232.
  • The checkout is unused in that job — the classify/label/register steps only call the GitHub API — so this PR removes it instead of opting into allow-unsafe-pr-checkout: true.
  • start_submission (maintainer-triggered workflow_dispatch) is untouched.

Because pull_request_target runs the workflow definition from base main, this fix must be merged before any fork PR's register_submission job can go green — it cannot fix itself from a PR branch.

Test plan

pull_request_target labeling only needs the Pulls API; checking out fork heads trips the pwn-request guard and was failing every miner PR.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant