🐍 Ensure support for Python 3.12/3.8/3.7 #962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README claims that Python 3.7 or higher is required, so I believe it would be nice to ensure that all 3.7+ versions are actually supported by enabling testing against them on CI. These changes also: - add coverage reporting - disable the fail-fast mode for tests - make CI use pipx to install poetry - make CI use pytest to run tests - force colors on CI - bump actions/checkout to v4 - bump actions/setup-python to v5
|
Hello @mingrammer, Would you mind reviewing this PR? Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋🏻 Hello @mingrammer,
First of all, thank you for this great project! 🙇🏼
The README claims that Python 3.7 or higher is required, so I believe it would be nice to ensure that all 3.7+ versions are actually supported by enabling testing against them on CI.
These changes also:
fail-fastmode for testspipxto installpoetrypytestto run testsYou can review a test run here 👀
Best regards!