Skip to content

Conversation

@Mee-gu
Copy link

@Mee-gu Mee-gu commented Dec 14, 2018

  • minggo/metal-support:
    support tile map
    handle blend function correctly
    LabelAtlas work
    Feature/update label (Feature/update label #149)
    support partcile system

Conflicts:

cocos/2d/CCLabel.cpp

cocos/2d/CCSprite.cpp

cocos/2d/CCSpriteBatchNode.cpp

cocos/renderer/CCQuadCommand.cpp

cocos/renderer/CCQuadCommand.h

* minggo/metal-support:
  support tile map
  handle blend function correctly
  LabelAtlas work
  Feature/update label (cocos2d#149)
  support partcile system

# Conflicts:
#	cocos/2d/CCLabel.cpp
#	cocos/2d/CCSprite.cpp
#	cocos/2d/CCSpriteBatchNode.cpp
#	cocos/renderer/CCQuadCommand.cpp
#	cocos/renderer/CCQuadCommand.h
_vertexBuffers.clear();
}

void CommandBufferGL::setLineWidth(float_t lineWidth)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

float_t -> float

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it.

else
{
glBufferData(GL_ARRAY_BUFFER, size, data, GL_STATIC_DRAW);
glBufferData(GL_ARRAY_BUFFER, _size, data, GL_STATIC_DRAW);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will cause performance issue.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@minggo minggo merged commit 326c382 into minggo:metal-support Dec 19, 2018
@Mee-gu Mee-gu deleted the feature/supportUnderLineEffect branch December 19, 2018 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants