bags change

[DragonWrangler1]

this pr will allow players to stack bags when in the main inventory, so they take up less room.

[SmallJoker]

I can see your motivation but bags are a such powerful item that they should not be made easier to obtain and store than they already are. They deliberately were registered as tools because that function automatically sets the stack size to 1.

[fluxionary]

i'm personally in favor of stackable bags, but it's not sufficient to just change them to craftitems and be done with it. you also need to ensure that the bag slots only ever end up with single bags inside them - it would be confusing to have 99 bags in a slot and only be able to "use" one of them for storage.

[SmallJoker]

it would be confusing to have 99 bags in a slot and only be able to "use" one of them for storage.

Player inventory callbacks can limit the maximal stack size per move action. There is no issue in that regard.

[DragonWrangler1]

fluxionary: I already tested and each of the 4 bag slots only allow for one bag in them.

[SmallJoker]

Thank you for your contribution. However, the bags are not supposed to be stackable to not make them easier to obtain than they already are. The registration as tool was intentional.

[fluxionary]

would this proposal have a chance if it was a non-default setting?

[SmallJoker]

Perhaps. I can imagine this being a 5-liner PR (in Lua) if done correctly.