3d_armor mt_0.5.0-dev support

[tacotexmex]

With 3d_armor mt_0.5.0-dev branch the player stands halfway through the ground.

[bell07]

I did not tested mt_0.5.0-dev, heard about some changes for player but do not know the details.

Do you use 0.5.0-dev Minetest? Does 3d_armor mt_0.5.0-dev work for you without skinsdb?

I know the issue I need to port some functions to "player_api" if 0.5. is there.

Agree, the skinsdb is not ready for 0.5.0 yet, as the most of my mods. I use the stable engine only so I can fix it if 0.5.0 is released. But Patching ideas and Pull-Requests welcome

One try: Please replace the "skinsdb/models/skinsdb_3d_armor_character.b3d" file by the file 3d_armor_character.b3d (from 3d_Armor mt_0.5.0-dev). Just copy from 3d_armor and rename / replace the file. I use the models from @stujones11 since 1.8-skins support.

[SmallJoker]

After these months of development I actually don't remember when the player collision box and its model got changed to the new 0m offset -- however, previously the model had its origin at 1m above ground, which is now at exactly 0m (feet position). Just a hit & miss idea: check whether player_api exists. If it exists, use the new model , if not: keep the current existing one to provide 0.4.?? compatibility.

[bell07]

@SmallJoker , is the player_api/models/character.b3d useable for 3d_armor and 1.8er Skins? Or I still need to use the 3d_armor model?

[bell07]

Just for reference, for player_api I proposed some changes for better skins support: luanti-org/minetest_game#1965 (comment)

[SmallJoker]

@bell07 Because it's skinsdb which seems to specify the used player model, the 3d_armor model with 1.8 skin support should be used to ensure the armor compatibility. player_api is the minimal model, which supports neither armor nor extended skins.

[bell07]

Initial work done in https://github.com/bell07/minetest-skinsdb/tree/mt_0_5_dev
@tacotexmex , can you please test? I do not have 0.5 for testing (I am stable user)

[tacotexmex]

Will test, thanks alot for this effort!

[tacotexmex]

The issue persists I'm afraid.

[bell07]

Do you use minetest_game-0.5-dev or have the player_api mod? The "if" check for player_api to decide which implementation should be used

[tacotexmex]

I use the latest engine with the latest minetest_game. It has the player_api mod.

[bell07]

Ok, now compiled 0.5-dev to test this issue ...

Played arround and found out, if you use playeranim mod, you need to set

player_model_version = default_character_v3

to you minetest.conf to get it working. No changes necessary in skinsdb this way.

Without playeranim my last changes does work with 3d_armor and without. Ok, with 3d_armor I nab wrong model file, updated to the right one now.

Pls. noe the current mt_0_5_dev is a temporary solution till luanti-org/minetest_game#2122 is completed, so I do not merge them to minetest-mods

[tacotexmex]

I can now also get it working properly with 3d_armor(mt_0.5.0-dev)+skinsdb. However, I also use multiskin mod so with this mod activated as well the bug persists. But that's an issue with multiskin, right?

[bell07]

I did not tested the skinsdb and multiskin together because I just did not understand the multiskin. So asume the mods are not compatible and maybe redundant. Most usefull things I seen in multiskin I ported to skinsdb.

What is your use-case? Why you need the multiskin?

[tacotexmex]

I added it because I thought that I needed it for the multilayered skin support. (1.8)

[bell07]

Yea, in April I ported the 1.8. skins support from multiskin to skinsdb in a way the "master" 3d_armor can be used. So just place the 1.8er Skins to the skinsdb textures folder. I recommend in addition to create preview files and meta-files to be shown in inventory.