Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize mvps_push_or_pull #662

Closed
wants to merge 11 commits into from
Closed

optimize mvps_push_or_pull #662

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
00359e7
add profiling debug prints
lolbinarycat Dec 17, 2023
ba9b250
don't check for sticky blocks in locations that are already being pushed
lolbinarycat Dec 17, 2023
bc9ed16
more optimization of inner loops related to mvps_push
lolbinarycat Dec 17, 2023
a7c8146
micro-optimization: eliminate index in inner loop
lolbinarycat Dec 17, 2023
5be0ee9
add fifo_queue.add_list() and use it to eliminate an inner loop
lolbinarycat Dec 17, 2023
43a568d
store result of table lookup in local variable, improving performance…
lolbinarycat Dec 17, 2023
22eae4b
mess with locals and hide debug prints
lolbinarycat Dec 17, 2023
068da0c
cleanup
lolbinarycat Dec 17, 2023
4c27c65
remove profiling stuff
lolbinarycat Dec 17, 2023
79214b5
revert local-variable lifting
lolbinarycat Dec 19, 2023
ab2df3c
add fallback implementation for fifo_queue.add_list() in case table.m…
lolbinarycat Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add fallback implementation for fifo_queue.add_list() in case table.m… 
…ove() is missing
  • Loading branch information
@lolbinarycat
lolbinarycat committed Dec 19, 2023
commit ab2df3caf31cb3877b5f37b2e778cf0448f0adeb
17 changes: 13 additions & 4 deletions mesecons/fifo_queue.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,19 @@ function fifo_queue.add(self, v)
self.buf_in[n] = v
end

-- add several elements to the queue
function fifo_queue.add_list(self, v)
table.move(v, 1, #v, self.n_in + 1, self.buf_in)
self.n_in = self.n_in + #v
-- table.move is not available in some lua versions, provide a fallback implementaion
if table.move ~= nil then
-- add several elements to the queue
function fifo_queue.add_list(self, v)
table.move(v, 1, #v, self.n_in + 1, self.buf_in)
self.n_in = self.n_in + #v
end
else
function fifo_queue.add_list(self, v)
for _, elem in ipairs(v) do
self:add(elem)
end
end
end
-- removes and returns the next element, or nil of empty
function fifo_queue.take(self)
Expand Down
Loading