Prepare minor release #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mariux
commented
Jul 8, 2020
mariux
commented
- Update Makefile
- Add CHANGELOG.md
- Prepare for new minor release
- Fix example reference in index README
- Remove markdown link checker safeguards
| @@ -46,13 +46,18 @@ DOCKER_RUN_CMD = docker run ${DOCKER_FLAGS} ${BUILD_TOOLS_DOCKER_IMAGE} | |||
| .PHONY: default | |||
| default: help | |||
|
|
|||
| ## Run pre-commit hooks in build-tools docker container. | |||
| # not exported in make help on purpose, as this is a one-time shot to make life easier | |||
| .PHONY: template/adjust | |||
There was a problem hiding this comment.
tbH, after seeing this a couple of times and thinking about it. This should rather be a separate cool or simple alias in your local bashrc rather than part of the repo
There was a problem hiding this comment.
actually this should be a pre-commit to verify template cleanup has been done... like e.g. terraform fmt...
There was a problem hiding this comment.
okay, so what are the next steps here? Shall we put this to our backlog?
There was a problem hiding this comment.
not a priority at all.. let's see how often this process fails...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.