More Mixin Fixes #2471
Merged
More Mixin Fixes #2471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding our elements one by one lets some of them get frozen above the normal suggestions. Instead, we should add them all in a batch.
src/main/kotlin/platform/mixin/completion/InjectionPointTypedHandlerDelegate.kt
Outdated
Show resolved
Hide resolved
|
The |
|
As in I should inform them / make a PR there, or try to maintain bin compat? |
|
Trying to maintain binary compat is the best, but not at the expense of keeping our own codebase maintainable. We don't have many API consumers so we can get away with breaking binary compat as long as we inform the major ones (I can only think of MixinSquared tbh) |
|
I can inform them yeah, they don't have any injection points anyway so should be minor |
LlamaLad7
force-pushed
the
fix/mixin-fixes-2
branch
from
258c2ee to
3881882
Compare
This includes several related things like: - Rework `CollectVisitor`s to work with `Sequence`s rather than having a special case for only wanting the first result - Rework `CollectResultFilter`s to filter based on the whole sequence (this is needed to support `:LAST`) - Offer proper completion options for specifiers in the right context - Fix `At#value` completions disappearing after typing `:`
LlamaLad7
force-pushed
the
fix/mixin-fixes-2
branch
from
3881882 to
a9c3fab
Compare
|
The MixinSquared plugin needs no changes. |
Earthcomputer
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mixin shadow autocomplete results often being prioritized over regular java ones
Also adds much better support for injection point specifiers.
The latter required some decently big reworks to the
CollectVisitorsystem.During that I greatly improved the (previously nonexistent due to bugs) message about which filters were responsible for the failure.
Happy to debate any of the refactors if you disagree with them.
Also as a side note, I keep my commit history clean, so it would be preferable for my PRs not to be squashed.