-
Notifications
You must be signed in to change notification settings - Fork 89
Add Sam2 video #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Sam2 video #1434
Conversation
Summary of ChangesHello @zyd-ustc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the SAM2 video modeling capabilities into the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the Sam2VideoProcessor and Sam2VideoVideoProcessor for video modeling with SAM2. The changes include the necessary processing logic for handling video inputs, including points, boxes, and masks. The implementation is quite comprehensive.
My review focuses on improving code clarity, maintainability, and adherence to best practices. I've suggested:
- Using explicit imports instead of wildcards to improve code readability.
- Replacing
copy.deepcopywith the more idiomatic and efficient.clone()for tensor copying. - Correcting a malformed docstring.
- Removing an unused import.
These changes should help improve the overall quality of the new code.
mindone/transformers/models/sam2_video/processing_sam2_video.py
Outdated
Show resolved
Hide resolved
| """ | ||
| Validate a single input by ensuring proper nesting and raising an error if the input is not valid. | ||
|
|
||
| Args: | ||
| data (`ms.Tensor`, `np.ndarray`, or `list`): | ||
| Input data to process. | ||
| expected_depth (`int`): | ||
| Expected nesting depth. | ||
| input_name (`str`): | ||
| Name of the input for error messages. | ||
| expected_format (`str`): | ||
| The expected format of the input. | ||
| expected_coord_size (`int`, *optional*): | ||
| Expected coordinate size (2 for points, 4 for boxes, None for labels). | ||
| . | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring for this method appears to be malformed. The first line is incorrectly indented, and there's a stray period at the end. This should be corrected for better documentation clarity.
"""Validate a single input by ensuring proper nesting and raising an error if the input is not valid.
Args:
data (`ms.Tensor`, `np.ndarray`, or `list`):
Input data to process.
expected_depth (`int`):
Expected nesting depth.
input_name (`str`):
Name of the input for error messages.
expected_format (`str`):
The expected format of the input.
expected_coord_size (`int`, *optional*):
Expected coordinate size (2 for points, 4 for boxes, None for labels).
"""Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
What does this PR do?
Adds # (feature)
1.add sam2_video model
2.add sam2_video processor
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx