Skip to content

基于CCPD的车牌号检测和识别案例 #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 28, 2024
Merged

Conversation

Xv-M-S
Copy link
Contributor

@Xv-M-S Xv-M-S commented Sep 29, 2024

Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:

Motivation

(Write your motivation for proposed changes here.)
【开源实习】基于MindOCR的车牌识别案例输出 (https://gitee.com/mindspore/community/issues/I98K8W)

Test Plan

(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)

Related Issues and PRs

【开源实习】基于MindOCR的车牌识别案例输出 (https://gitee.com/mindspore/community/issues/I98K8W)
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

@panshaowu
Copy link
Collaborator

@Xv-M-S 请先根据CI测试报告,修改代码规范问题,并在完成后,提示管理员重新触发CI,直至通过。。

@Xv-M-S
Copy link
Contributor Author

Xv-M-S commented Oct 8, 2024 via email

@Xv-M-S
Copy link
Contributor Author

Xv-M-S commented Oct 8, 2024

潘导你好,已根据CI测试报告完成代码的修改,怎么提示管理员触发CI呢?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处能否不修改源码,而在配置里或命令行里设定相关阈值

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在源代码 https://github.com/mindspore-lab/mindocr/blob/main/mindocr/metrics/det_metrics.py#L108 调用DetectionIoUEvaluator初始化时为提供任何参数,导致只能使用默认参数;在配置文件的metric处也没有提供关于iou的修改
https://github.com/mindspore-lab/mindocr/blob/main/docs/zh/tutorials/yaml_configuration.md#5-%E8%AF%84%E4%BC%B0%E6%8C%87%E6%A0%87-metric

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议类似的黑底截图尽量转成 插入文本的方式,格式舒适些

postprocess:
    name: abc
    ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

导师你好,已按照要求修改

@Xv-M-S
Copy link
Contributor Author

Xv-M-S commented Oct 8, 2024

已根据第二次CI测试报告修改代码

@kk928290341
Copy link
Collaborator

建议py文件以文本形式写进md,docs目录下不要放代码文件和配置文件

@Xv-M-S
Copy link
Contributor Author

Xv-M-S commented Oct 8, 2024

已将代码和配置文件以附录形式放入md

@Xv-M-S
Copy link
Contributor Author

Xv-M-S commented Oct 9, 2024

已根据第三次CI测试报告修改代码

@Xv-M-S
Copy link
Contributor Author

Xv-M-S commented Oct 9, 2024

image
这次CI测试报告说C++源码有问题,但我这没有对C++代码做改动

@kk928290341
Copy link
Collaborator

c++问题pr#747已修复,请更新一次代码重新触发门禁

@Xv-M-S
Copy link
Contributor Author

Xv-M-S commented Oct 10, 2024

已更新代码

@kk928290341
Copy link
Collaborator

麻烦创建一个examples文件夹,将输出案例整理在该文件夹下,可放代码和配置文件,感谢!参考https://github.com/mindspore-lab/mindyolo/tree/master/examples

@Xv-M-S
Copy link
Contributor Author

Xv-M-S commented Oct 16, 2024

已将输出案例移动到examples文件夹下,并添加了代码和配置文件

@CaitinZhao CaitinZhao merged commit 2c6c27e into mindspore-lab:main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants