Bugfix of svtr when the input is FP16 or FP32 for MindSpore r2.3rc1 #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panshaowu
approved these changes
Mar 29, 2024
panshaowu
changed the title
Bourn3z
force-pushed
the
bugfix_svtr_gridsample
branch
from
87b8ca7 to
262dc07
Compare
panshaowu
approved these changes
Mar 29, 2024
chengtianwu
approved these changes
Mar 29, 2024
| @@ -129,3 +130,4 @@ def construct( | |||
| grid = 2.0 * grid - 1.0 | |||
| output_maps = grid_sample(input, grid, canvas=None) | |||
| return output_maps, source_coordinate | |||
| np.gridsample | |||
Bourn3z
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:
Motivation
解决已知问题：当amp_level = 'O2'时，即网络输入为FP16时，grid_sample有计算问题。因此将算子输入手动转换到FP64计算。
临时规避方案，待r2.3.0修复grid_sample计算问题后，应回退该PR。
Solve known issues: When amp_level = 'O2', that is, when the network input is FP16, grid_sample has calculation problems. Therefore, the input is manually cast to FP64.
(Write your motivation for proposed changes here.)
Test Plan
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)