Remove dependency of mindformers #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horcham
force-pushed
the
abinet
branch
5 times, most recently
from
fbc171a to
a9d4e9c
Compare
horcham
changed the title
horcham
force-pushed
the
abinet
branch
7 times, most recently
from
8d9489d to
da1e183
Compare
horcham
force-pushed
the
abinet
branch
4 times, most recently
from
fdfcd5b to
3d64e51
Compare
panshaowu
approved these changes
Feb 23, 2024
| RuntimeError: Run task for graph:kernel_graph_1 error! The details reger to 'Ascend Error Message' | ||
| ``` | ||
|
|
||
| 请尝试将CANN更新到7.1。 |
There was a problem hiding this comment.
请尝试将CANN升级到与MindSpore版本匹配的7.1版本。
请看下这样阐述是否更准确？
There was a problem hiding this comment.
backbones下已有一个mindcv_models，请注意命名格式统一是否更好，比如取名mindformers_models。
或者直接将layers.py取一个合适的名字（比如transformer_layers.py或mindformers_layers.py），放在mindcv_models文件夹下。
There was a problem hiding this comment.
- 删除license
- 本文件在MindSpore主仓中有（mindspore\python\mindspore\parallel_transformer\moe.py），可以直接引用。
There was a problem hiding this comment.
mindspore已有类似文件mindspore\python\mindspore\parallel_transformer\transformer.py，建议考虑优先复用。
There was a problem hiding this comment.
mindspore主仓已有类似文件mindspore\python\mindspore\parallel_transformer\op_parallel_config.py，建议考虑优先复用。
There was a problem hiding this comment.
mindspore主仓下的mindspore\python\mindspore\parallel_transformer\layers.py是否可复用？
chengtianwu
approved these changes
Feb 23, 2024
panshaowu
added a commit
that referenced
this pull request
Feb 29, 2024
* Remove dependency of mindformers (#666) * Fix problems of psenet-ctw1500 training * Fix problems of psenet-ctw1500 training * Fix problems of psenet-ctw1500 training * remove mindformers * Fix problems of psenet-ctw1500 training * remove dependency * use transformer from mindspore * remove code from mindformers * revise the readme of CRNN (#672) * revise whl deploy setting and version info * fix issue #470 * revise the readme of CRNN --------- Co-authored-by: panshaowu <panshaowu@huawei.com> * fix data bug (#673) --------- Co-authored-by: horcham <690936541@qq.com> Co-authored-by: panshaowu <panshaowu@huawei.com> Co-authored-by: chengtianwu <53269662+chengtianwu@users.noreply.github.com>
panshaowu
added a commit
that referenced
this pull request
Mar 22, 2024
* add mindformers as submodule * vary qwen * adapt graph mode * add CLIP for Vary * sync behind commit from main (#675) * Remove dependency of mindformers (#666) * Fix problems of psenet-ctw1500 training * Fix problems of psenet-ctw1500 training * Fix problems of psenet-ctw1500 training * remove mindformers * Fix problems of psenet-ctw1500 training * remove dependency * use transformer from mindspore * remove code from mindformers * revise the readme of CRNN (#672) * revise whl deploy setting and version info * fix issue #470 * revise the readme of CRNN --------- Co-authored-by: panshaowu <panshaowu@huawei.com> * fix data bug (#673) --------- Co-authored-by: horcham <690936541@qq.com> Co-authored-by: panshaowu <panshaowu@huawei.com> Co-authored-by: chengtianwu <53269662+chengtianwu@users.noreply.github.com> * add SAM for Vary * add data process and speed up vary * speed up vary * add generation * add chat vary --------- Co-authored-by: w00517672 <wutiancheng@huawei.com> Co-authored-by: panshaowu <panshaowu@huawei.com> Co-authored-by: horcham <690936541@qq.com> Co-authored-by: chengtianwu <53269662+chengtianwu@users.noreply.github.com>
horcham
added a commit
to horcham/mindocr
that referenced
this pull request
Apr 19, 2024
* Fix problems of psenet-ctw1500 training * Fix problems of psenet-ctw1500 training * Fix problems of psenet-ctw1500 training * remove mindformers * Fix problems of psenet-ctw1500 training * remove dependency * use transformer from mindspore * remove code from mindformers
panshaowu
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Fix problems of psenet-ctw1500 training * update doc * Remove dependency of mindformers (#666) * Fix problems of psenet-ctw1500 training * Fix problems of psenet-ctw1500 training * Fix problems of psenet-ctw1500 training * remove mindformers * Fix problems of psenet-ctw1500 training * remove dependency * use transformer from mindspore * remove code from mindformers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:
Motivation
该变更不会引入影响，原因如下：
(Write your motivation for proposed changes here.)。
Test Plan
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)