PSEDiceLoss support any input shape (fix issue#333) #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangxhao
approved these changes
Jun 1, 2023
SamitHuang
reviewed
Jun 1, 2023
| @@ -615,17 +603,15 @@ def __call__(self, data: dict): | |||
| poly = poly.intersection(border) | |||
There was a problem hiding this comment.
use poly.is_valid before poly.intersection to avoid errors.
There was a problem hiding this comment.
But line594 already tested poly.is_valid: if (not poly.is_valid) or (poly.is_empty):
| else: # the polygon is fully outside the image | ||
| continue | ||
| new_tags.append(ignore) | ||
| new_texts.append(text) | ||
|
|
||
| data['polys'] = new_polys | ||
| data['polys'] = np.array(new_polys) # need to use numpy.ndarray |
There was a problem hiding this comment.
Added, but ci failed with this 😥
There was a problem hiding this comment.
Good suggestion, reverted.
HaoyangLee
approved these changes
Jun 2, 2023
hadipash
approved these changes
Jun 2, 2023
| @@ -215,22 +216,24 @@ def ohem_batch(self, scores, gt_texts, training_masks): | |||
| return selected_masks | |||
|
|
|||
| def ohem_single(self, score, gt_text, training_mask): | |||
| h, w = score.shape[0:2] | |||
| k = int(h * w) | |||
There was a problem hiding this comment.
Not important in this case because we don't support dynamic shaping, but for the future:
during the graph construction all constants (integers, floats, etc.) will be calculated once and will not be changed during execution anymore. So, need to be careful if you intend k to change.
VictorHe-1
force-pushed
the
predict
branch
2 times, most recently
from
9cad2ba to
f639f1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:
Motivation
Fix issue#333 and modify some codes according the comments of Rustam.
Test Plan
Already tested on CTW1500 dataset with shape (736, 736)
Related Issues and PRs
Issues: #333
PR: #290