Skip to content

Add ppocr series models #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

VictorHe-1
Copy link
Collaborator

@VictorHe-1 VictorHe-1 commented May 23, 2023

Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:

Motivation

  1. 适配ppocr系列模型,增加ppocr系列模型的推理配置文件,以及进行模型注册。

Test Plan

(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

img_mode: BGR
channel_first: False
to_float32: True
- CTCLabelEncode:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CTCLabelEncode在预处理里面用不到吧?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,增加在preprocess_skip_ops里面了,只是增加个示例

mean: imagenet
std: imagenet
is_hwc: True
- ToCHWImage:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件末尾要有换行符

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

- DecodeImage:
img_mode: BGR
channel_first: False
- ResizeImage:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

映射为keep_ratio=True的Resize,即ScalePadImage

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

@liangxhao liangxhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better!
TODO: 后续补充Readme文档,以及精度性能测试结果

@VictorHe-1
Copy link
Collaborator Author

ok

Copy link
Collaborator

@SamitHuang SamitHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

存疑点:server / mobile naming

@SamitHuang SamitHuang merged commit 7783ec7 into mindspore-lab:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants