Add unified resize operation for detection and a resize op for recognition inference #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
HaoyangLee
reviewed
May 18, 2023
| @@ -312,7 +317,7 @@ class ValidatePolygons: | |||
| Args: | |||
| min_area: minimum area below which newly clipped polygons considered as ignored. | |||
| """ | |||
| def __init__(self, min_area: float = 1.0): | |||
| def __init__(self, min_area: float = 1.0, min_poly_points: int=4,): | |||
There was a problem hiding this comment.
min_poly_points has conflict with PR #292
| interpoloation: interpolation method | ||
|
|
||
| Note: | ||
| 1. The default choices limit_type=min, padding=False with large `target_limit_side` are recommended for inference in detection for bettr accuracy, |
| assert target_size is not None, f'target_size must be set if aspect ratio changes or limit_type is auto' | ||
|
|
||
| if keep_ratio and padding and force_divisable: | ||
| print(f'WARNING: `padding` and `force_divisable` are confilicting after aspect-ratio-kept resizing. `force_divisable` will not make effect.') |
There was a problem hiding this comment.
typo: confilicting -> conflicting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:
Motivation
(Write your motivation for proposed changes here.)
Test Plan
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)