Skip to content

Add loss average meter #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

zhtmike
Copy link
Collaborator

@zhtmike zhtmike commented May 12, 2023

Solve #281

Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:

Motivation

(Write your motivation for proposed changes here.)

Test Plan

(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

@zhtmike zhtmike requested review from SamitHuang, hadipash and hqkate May 12, 2023 08:31
Copy link
Collaborator

@SamitHuang SamitHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it is the oldest implementation. but how does this chage solve the bug?

@zhtmike
Copy link
Collaborator Author

zhtmike commented May 12, 2023

actually it is the oldest implementation. but how does this chage solve the bug?

on Ascend, the loss list's length exceeds the maximum length of ops.stack can handle, then it raise RuntimeError. It is a low-level API limitation

@zhtmike zhtmike merged commit 8e28357 into mindspore-lab:main May 12, 2023
@zhtmike zhtmike deleted the loss_avg_meter branch May 15, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants