Add gradient accumulation and grad clip and update readme (grad reduce after accumulate, make lr scheduling consistent) #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhtmike
approved these changes
Apr 24, 2023
…de after accumulate, consistent lr scheduling fixed)
HaoyangLee
approved these changes
Apr 24, 2023
SamitHuang
changed the title
SamitHuang
changed the title
colawyee
pushed a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…de after accumulate, consistent lr scheduling fixed)
Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:
Motivation
Add gradient accumulation for training with large batch size under limited memory. Improved over previous PR: grad reduce after accumulate, make lr scheduling consistent by stepping without updating network when accumulating.
Add grad clip to configure more stable training.
Update readme
Test Plan
(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)
Related Issues and PRs
(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)