Skip to content

update dataset converter readme #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2023
Merged

update dataset converter readme #107

merged 3 commits into from
Mar 27, 2023

Conversation

wtomin
Copy link
Collaborator

@wtomin wtomin commented Mar 27, 2023

Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:

Motivation

update the dataset converter readme, include covnert_datasets.sh, and Chinese readme fiels

Test Plan

(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

@HaoyangLee
Copy link
Collaborator

HaoyangLee commented Mar 27, 2023

建议在docs/en/datasets/docs/cn/datasets/下的每个README内加上说明和链接分别指向tools/dataset_converters/的README.md和README_CN.md,方便用户在下载数据后进行数据格式转换。

@wtomin
Copy link
Collaborator Author

wtomin commented Mar 27, 2023

我在末尾添加了返回README链接, 还需要其他说明吗?

Copy link
Collaborator

@SamitHuang SamitHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamitHuang SamitHuang merged commit 4329259 into mindspore-lab:main Mar 27, 2023
colawyee pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants