-
Notifications
You must be signed in to change notification settings - Fork 48
Fix for an unconvential usage of Mocket #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
amotl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear Giorgio,
thank you very much for this patch. It looks like it will resolve the problem reported at #191 and hiveeyes/terkin-datalogger#117.
On this matter, I wanted to let you know that one unfortunately can not install the package directly from its Git repository using this command:
pip install "git+https://github.com/mindflayer/python-mocket@fix/issue-191"
It croaks like:
FileNotFoundError: [Errno 2] No such file or directory: '/private/var/folders/06/w9pzygdj7vx53n_0l9q_lhph0000gn/T/pip-req-build-9h5ttlf8/requirements.txt'No problem so far, I will clone the repository and install the package manually. I just wanted to mention it that it might get a chance to be improved in the future.
With kind regards,
Andreas.
pip install "git+https://github.com/mindflayer/python-mocket@fix/issue-191"
| - uses: actions/checkout@v3 | ||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v2 | ||
| uses: actions/setup-python@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to support Python 3.5 and 3.6 with actions/setup-python@v4, you will need to downgrade to ubuntu-20.04.
Otherwise, maybe downgrade to actions/setup-python@v3, but this lacks integrated package caching, which is an excellent feature of the new actions/setup-python@v4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was v2 when it first failed.
|
|
||
|
|
||
| class Mocket: | ||
| _address = (None, None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
e8bf577 to
f6f5232
Compare
Those commands had to be invoked within the repository tree, ... in order to make the package pip-installable from another location: After installing it, Terkin's LoRaWAN test cases, where we apparently used Mocket unconventionally, succeed again. Thank you so much! With kind regards, |
f6f5232 to
1bf7643
Compare
.github/workflows/main.yml
Outdated
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #192 (comment).
1bf7643 to
ea8156f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
I am making Mocket's CI great again, give me a moment and I'll release a new version. |
|
I had to do this to make it work again. |








See #191 for details.