Skip to content

Conversation

@mindflayer
Copy link
Owner

See #191 for details.

Copy link
Contributor

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Giorgio,

thank you very much for this patch. It looks like it will resolve the problem reported at #191 and hiveeyes/terkin-datalogger#117.

On this matter, I wanted to let you know that one unfortunately can not install the package directly from its Git repository using this command:

pip install "git+https://github.com/mindflayer/python-mocket@fix/issue-191"

It croaks like:

FileNotFoundError: [Errno 2] No such file or directory: '/private/var/folders/06/w9pzygdj7vx53n_0l9q_lhph0000gn/T/pip-req-build-9h5ttlf8/requirements.txt'

No problem so far, I will clone the repository and install the package manually. I just wanted to mention it that it might get a chance to be improved in the future.

With kind regards,
Andreas.

pip install "git+https://github.com/mindflayer/python-mocket@fix/issue-191"

- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v4
Copy link
Contributor

@amotl amotl Dec 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to support Python 3.5 and 3.6 with actions/setup-python@v4, you will need to downgrade to ubuntu-20.04.

Otherwise, maybe downgrade to actions/setup-python@v3, but this lacks integrated package caching, which is an excellent feature of the new actions/setup-python@v4.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was v2 when it first failed.



class Mocket:
_address = (None, None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amotl
Copy link
Contributor

amotl commented Dec 3, 2022

I will clone the repository and install the package manually.

Those commands had to be invoked within the repository tree,

pip install pipfile
python -c "import pipfile; pf = pipfile.load('Pipfile'); print('\n'.join(package+version for package, version in pf.data['default'].items()))" > requirements.txt

... in order to make the package pip-installable from another location:

pip install /path/to/python-mocket

After installing it, Terkin's LoRaWAN test cases, where we apparently used Mocket unconventionally, succeed again. Thank you so much!

With kind regards,
Andreas.

jobs:
build:

runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mindflayer
Copy link
Owner Author

I am making Mocket's CI great again, give me a moment and I'll release a new version.

@mindflayer
Copy link
Owner Author

I had to do this to make it work again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants