Skip to content

Remove assert statement from non-test files #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mindflayer merged 1 commit into from
Mar 29, 2022
Merged

Remove assert statement from non-test files #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions mocket/mocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,8 @@ def enable(namespace=None, truesocket_recording_dir=None):

if truesocket_recording_dir:
# JSON dumps will be saved here
assert os.path.isdir(truesocket_recording_dir)
if not os.path.isdir(truesocket_recording_dir):
raise AssertionError

socket.socket = socket.__dict__["socket"] = MocketSocket
socket._socketobject = socket.__dict__["_socketobject"] = MocketSocket
Expand Down Expand Up @@ -547,9 +548,10 @@ def get_truesocket_recording_dir(cls):
@classmethod
def assert_fail_if_entries_not_served(cls):
"""Mocket checks that all entries have been served at least once."""
assert all(
if not all(
entry._served for entry in itertools.chain(*cls._entries.values())
), "Some Mocket entries have not been served"
):
raise AssertionError("Some Mocket entries have not been served")


class MocketEntry:
Expand Down